Review main Merged

65362[BUGFIX] Correctly show changes in current workspace in the page tree

Richard Haeser CR +2 V +2 Hard +286 −78 updated 09/04/20, 06:20

Commit message

Pages that are deleted or moved in the current workspace are shown
correctly in the page tree now, especially when fetching
pages only on a specific level or when filtering.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Richard Haeser +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Richard Haeser +1
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 4

Files 4

Review log 4263

Show 2238 earlier messages
  1. Richard Haeser uploaded patch set 1 08/18/20, 11:29

  2. TYPO3com voted on patch set 1 V +1 08/18/20, 11:40 Completed build in 11m 44s on Tue, 18 Aug, 11:40 AM Test Summary: 72998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4756

  3. Oliver Hader commented on patch set 1 08/24/20, 16:56

    → confirmed report in issue #92057 (deleted pages in workspace) which probably should be handled with this change as well..
  4. Oliver Hader updated the commit message in patch set 2 08/24/20, 17:15

  5. TYPO3com voted on patch set 2 V +1 08/24/20, 17:28 Completed build in 12m 32s on Mon, 24 Aug, 05:28 PM Test Summary: 73074 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4915

  6. Richard Haeser uploaded patch set 3 08/24/20, 20:25

  7. TYPO3com voted on patch set 3 V -1 08/24/20, 21:01 Completed build in 13m 28s on Mon, 24 Aug, 09:01 PM Test Summary: 73074 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4925

  8. TYPO3com commented on patch set 3 08/24/20, 21:05 Completed build in 32m 27s on Mon, 24 Aug, 09:05 PM Test Summary: 20 of 62832 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4924

  9. TYPO3com commented on patch set 3 08/24/20, 21:06 Completed build in 41m 29s on Mon, 24 Aug, 09:06 PM Test Summary: 287 of 70807 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4923

  10. TYPO3com voted on patch set 3 V +1 08/25/20, 06:55 Completed build in 12m 08s on Tue, 25 Aug, 06:55 AM Test Summary: 73074 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4929

  11. Tymoteusz Motylewski commented on patch set 3 08/25/20, 08:02

    Richard, would you be able to extend TYPO3\CMS\Backend\Tests\Functional\Controller\Page\TreeControllerTest to cover this case with test? I believe this test was covering a situation like that before the async fetching of page tree, so most probably a new test needs to be written to request some subtree where a page is moved or deleted.
  12. Richard Haeser commented on patch set 3 08/25/20, 08:03

    > Patch Set 3: > > Richard, would you be able to extend TYPO3\CMS\Backend\Tests\Functional\Controller\Page\TreeControllerTest to cover this case with test? > I believe this test was covering a situation like that before the async fetching of page tree, so most probably a new test needs to be written to request some subtree where a page is moved or deleted. Yeah, the missing test is the reason to be WIP
  13. Richard Haeser updated the commit message in patch set 4 08/25/20, 08:03

  14. TYPO3com voted on patch set 4 V +1 08/25/20, 08:16 Completed build in 12m 50s on Tue, 25 Aug, 08:16 AM Test Summary: 73074 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4935

  15. Oliver Hader wrote 08/25/20, 10:47

    Change message removed by: Stephan Großberndt
  16. Oliver Hader wrote 08/25/20, 10:47

    Change message removed by: Oliver Hader
  17. Oliver Hader wrote 08/25/20, 10:47

    Topic set to #
  18. Oliver Hader wrote 08/25/20, 10:47

    Change message removed by: Oliver Hader
  19. Oliver Hader wrote 08/25/20, 10:48

    Change message removed by: Stephan Großberndt
  20. Richard Haeser uploaded patch set 5 08/25/20, 12:05

  21. TYPO3com voted on patch set 5 V +1 08/25/20, 12:18 Completed build in 13m 16s on Tue, 25 Aug, 12:18 PM Test Summary: 73074 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4948

  22. Oliver Hader commented on patch set 5 08/25/20, 13:44

    das

    PageTreeRepository.php:266 Unresolved

    Not sure, but `$livePagePids` does not seem to be used at all in this function - what's it supposed to be used for?
  23. Oliver Hader uploaded patch set 6 08/25/20, 15:11

  24. Oliver Hader commented on patch set 6 V -1 08/25/20, 15:13

    Added tests for the parts that are not working, yet
  25. TYPO3com voted on patch set 6 V -1 08/25/20, 15:23 Completed build in 11m 54s on Tue, 25 Aug, 03:23 PM Test Summary: 14 of 73577 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4952

  26. Richard Haeser uploaded patch set 7 08/25/20, 20:31

  27. TYPO3com voted on patch set 7 V -1 08/25/20, 21:10 Completed build in 38m 45s on Tue, 25 Aug, 09:10 PM Test Summary: 60 of 72297 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4963

  28. TYPO3com commented on patch set 7 08/26/20, 06:14 Completed build in 46m 39s on Wed, 26 Aug, 06:14 AM Test Summary: 7 of 73126 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4969

  29. Oliver Hader uploaded patch set 8 08/26/20, 16:27

  30. TYPO3com voted on patch set 8 V -1 08/27/20, 07:13 Completed build in 12m 12s on Thu, 27 Aug, 07:13 AM Test Summary: 10 of 73076 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4995

  31. Richard Haeser updated the commit message in patch set 9 08/27/20, 08:17

  32. TYPO3com voted on patch set 9 V -1 08/27/20, 08:57 Completed build in 37m 12s on Thu, 27 Aug, 08:57 AM Test Summary: 10 of 73595 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4998

  33. Benni Mack uploaded patch set 10 09/01/20, 09:56

  34. TYPO3com voted on patch set 10 V -1 09/01/20, 10:08 Completed build in 11m 55s on Tue, 1 Sep, 10:08 AM Test Summary: 6 of 73667 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5097

  35. Benni Mack uploaded patch set 11 09/01/20, 11:00

  36. TYPO3com voted on patch set 11 V -1 09/01/20, 11:11 Completed build in 11m 13s on Tue, 1 Sep, 11:11 AM Test Summary: 3 of 73667 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5101

  37. Benni Mack uploaded patch set 12 09/01/20, 11:19

  38. TYPO3com voted on patch set 12 V -1 09/01/20, 11:31 Completed build in 11m 35s on Tue, 1 Sep, 11:31 AM Test Summary: 3 of 73667 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5102

  1. Benni Mack updated the commit message in patch set 13 09/01/20, 11:32

  2. TYPO3com voted on patch set 13 V -1 09/01/20, 11:44 Completed build in 11m 53s on Tue, 1 Sep, 11:44 AM Test Summary: 3 of 73667 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5103

  3. Christian Kuhn uploaded patch set 14 09/01/20, 13:01

  4. TYPO3com voted on patch set 14 V -1 09/01/20, 13:12 Completed build in 10m 32s on Tue, 1 Sep, 01:12 PM Test Summary: 72652 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5107

  5. TYPO3com voted on patch set 14 V +1 09/01/20, 13:21 Completed build in 31m 02s on Tue, 1 Sep, 01:21 PM Test Summary: 73182 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5107

  6. Benni Mack updated the commit message in patch set 15 09/01/20, 13:25

  7. Benni Mack voted on patch set 15 V +1 CR +1 09/01/20, 13:25

  8. Christian Kuhn commented on patch set 14 09/01/20, 13:27

    Reason for the patch set 13 test fails: postgres searches case sensitive by default ("EN: Groups" vs. search word "groups). I fixed that by searching for "Groups" for now. The issue itself could later be resolved in the database ExpressionBuilder, which should probably either have an ->ilike() method that uses LIKE for all other dbms and ILIKE for postgres, or change ->like() to use ILIKE if creating a like expression for postgres.
  9. Christian Kuhn voted on patch set 15 V -1 09/01/20, 13:35

  10. TYPO3com voted on patch set 15 V +1 09/01/20, 13:35 Completed build in 10m 39s on Tue, 1 Sep, 01:35 PM Test Summary: 73182 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5108

  11. Christian Kuhn voted on patch set 15 V +1 CR +1 09/01/20, 13:40

  12. Christian Kuhn commented on patch set 15 V -1 CR 0 09/01/20, 13:53

    The scenario from Rachel from issue #91652 is still broken: * Go to workspace * Create page "parent" * Create 4 sub pages: page 11, page 12, page A, page 13 (in this order, so page A after 12 and before 13) * Use page tree drag & drop to move page A between 11 and 12 -> page tree does NOT reflect this move, list module shows correct order.
  13. Christian Kuhn commented on patch set 15 09/01/20, 13:54

    > Patch Set 15: Verified-1 -Code-Review > > The scenario from Rachel from issue #91652 is still broken: > * Go to workspace > * Create page "parent" > * Create 4 sub pages: page 11, page 12, page A, page 13 (in this order, so page A after 12 and before 13) > * Use page tree drag & drop to move page A between 11 and 12 > -> page tree does NOT reflect this move, list module shows correct order. See https://forge.typo3.org/issues/91652 for more description and an image.
  14. Benni Mack uploaded patch set 16 09/01/20, 15:01

  15. TYPO3com voted on patch set 16 V +1 09/01/20, 15:58 Completed build in 11m 42s on Tue, 1 Sep, 03:58 PM Test Summary: 73182 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5113

  16. Benni Mack voted on patch set 16 V +1 CR +1 09/01/20, 16:08

  17. Christian Kuhn voted on patch set 16 V +1 CR +1 09/01/20, 22:36

  18. Richard Haeser commented on patch set 16 V -1 09/02/20, 04:37

    While testing 91652, I found the following: - Create a new page in draft workspace - Search for the page title and you will find it at the right place - Move the page (in draft workspace) to another parent - Search for the page title and you will find the page at the old and the new location This is not the case when you created the page in live workspace, but moved it in draft.
  19. Benni Mack commented on patch set 16 09/02/20, 10:33

    > Patch Set 16: Verified-1 > > While testing 91652, I found the following: > > - Create a new page in draft workspace > - Search for the page title and you will find it at the right place > - Move the page (in draft workspace) to another parent > - Search for the page title and you will find the page at the old and the new location > > This is not the case when you created the page in live workspace, but moved it in draft. Hey Richard, this is actually a related issue, but not the same. This happened before already, and did not happen because of the pagetree change. This is now reflected in this change here: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65535
  20. Richard Haeser voted on patch set 16 V +1 CR +1 09/02/20, 13:51

  21. Richard Haeser commented on patch set 16 09/02/20, 13:51

    > Patch Set 16: > > > Patch Set 16: Verified-1 > > > > While testing 91652, I found the following: > > > > - Create a new page in draft workspace > > - Search for the page title and you will find it at the right place > > - Move the page (in draft workspace) to another parent > > - Search for the page title and you will find the page at the old and the new location > > > > This is not the case when you created the page in live workspace, but moved it in draft. > > Hey Richard, > > this is actually a related issue, but not the same. This happened before already, and did not happen because of the pagetree change. This is now reflected in this change here: > > https://review.typo3.org/c/Packages/TYPO3.CMS/+/65535 Great! Thanks a lot for your patchsets!!
  22. Benni Mack voted on patch set 16 V +2 CR +2 09/02/20, 14:28

  23. Benni Mack merged patch set 17 09/02/20, 14:28

  24. Richard Haeser commented on patch set 17 09/04/20, 06:17

    Ok, found an issue: - Rename an existing page in draft - New name of page is shown in page tree - Move the renamed page in draft to another parent - Old name of page is shown now Will create a new issue on forge for this
  25. Richard Haeser commented on patch set 17 09/04/20, 06:20

    > Patch Set 17: > > Ok, found an issue: > - Rename an existing page in draft > - New name of page is shown in page tree > - Move the renamed page in draft to another parent > - Old name of page is shown now > > Will create a new issue on forge for this https://forge.typo3.org/issues/92191