Review main Merged

65364[BUGFIX] Add missing default value for sitemap_priority column

Eric Chavaillaz CR +2 V +2 Easy +1 −0 updated 08/21/20, 16:33

Commit message

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
    • Jörg Bösche +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1215

  1. Eric Chavaillaz uploaded patch set 1 08/19/20, 08:32

  2. TYPO3com voted on patch set 1 V +1 08/19/20, 08:45 Completed build in 12m 19s on Wed, 19 Aug, 08:45 AM Test Summary: 72996 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4771

  3. Jörg Bösche voted on patch set 1 V +1 CR +1 08/20/20, 08:04

  4. Jörg Bösche commented on patch set 1 V 0 08/20/20, 08:06

    Should we provide a backport for version 9.5? The priority selection can also be found in the pages of the TCA configuration file.
  5. Eric Chavaillaz uploaded patch set 2 08/20/20, 08:21

  6. Eric Chavaillaz commented on patch set 2 08/20/20, 08:23

    > Patch Set 1: -Verified > > Should we provide a backport for version 9.5? The priority selection can also be found in the pages of the TCA configuration file. Yes we can backport. Set in patch 2.
  7. Jörg Bösche commented on patch set 2 08/20/20, 08:24

    > Patch Set 2: > > > Patch Set 1: -Verified > > > > Should we provide a backport for version 9.5? The priority selection can also be found in the pages of the TCA configuration file. > > Yes we can backport. Set in patch 2. Sorry, I made a mistake ... not 9.5, but 10.4 must be added as backport.
  8. Eric Chavaillaz updated the commit message in patch set 3 08/20/20, 08:28

  9. Eric Chavaillaz commented on patch set 2 08/20/20, 08:29

    > Patch Set 2: > > > Patch Set 2: > > > > > Patch Set 1: -Verified > > > > > > Should we provide a backport for version 9.5? The priority selection can also be found in the pages of the TCA configuration file. > > > > Yes we can backport. Set in patch 2. > > Sorry, I made a mistake ... not 9.5, but 10.4 must be added as backport. Oh my fault, done in patch 3.
  10. TYPO3com voted on patch set 2 V +1 08/20/20, 08:33 Completed build in 11m 30s on Thu, 20 Aug, 08:33 AM Test Summary: 72996 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4775

  11. TYPO3com voted on patch set 3 V +1 08/20/20, 08:41 Completed build in 12m 28s on Thu, 20 Aug, 08:41 AM Test Summary: 72996 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4776

  12. Jörg Bösche voted on patch set 3 V +1 CR +1 08/20/20, 09:59

  13. Christian Kuhn voted on patch set 3 V +1 CR +1 08/21/20, 16:30

  14. Andreas Kienast voted on patch set 3 V +2 CR +2 08/21/20, 16:33

  15. Andreas Kienast merged patch set 4 08/21/20, 16:33