Review main Merged

65365[BUGFIX] Fix return type hint for retrieveYamlFilesFromExtensionFolders

Kevin Ditscheid CR +2 V +2 Easy +1 −1 updated 08/31/20, 18:21

Commit message

The method retrieveYamlFilesFromExtensionFolders actually returns an array
of strings and not an array of File objects.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Alexander Schnitzler +1
    • Christian Kuhn +1
    • Jörg Bösche +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1113

  1. Kevin Ditscheid uploaded patch set 1 08/19/20, 08:36

  2. TYPO3com voted on patch set 1 V +1 08/19/20, 08:49 Completed build in 13m 04s on Wed, 19 Aug, 08:49 AM Test Summary: 72996 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4772

  3. Alexander Schnitzler commented on patch set 1 08/19/20, 10:16

    FormPersistenceManager.php:381

    Would be great to expand the type hint to array<string, string>
  4. Oliver Klee commented on patch set 2 08/19/20, 15:38

    Published edit on patch set 1.
  5. Oliver Klee commented on patch set 1 08/19/20, 15:39

    FormPersistenceManager.php:381 Reply

    Done
  6. TYPO3com voted on patch set 2 V +1 08/19/20, 15:50 Completed build in 11m 07s on Wed, 19 Aug, 03:50 PM Test Summary: 72996 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4773

  7. Jörg Bösche voted on patch set 2 V +1 CR +1 08/26/20, 13:31

  8. Alexander Schnitzler commented on patch set 2 CR +1 08/26/20, 13:37

    Why the backport to 10.4?
  9. Benni Mack commented on patch set 2 08/31/20, 10:00

    > Patch Set 2: Code-Review+1 > > Why the backport to 10.4? Hmm, maybe because it is declared as "bugfix"? but since this is a non-code-change, I'm fine with the backport.
  10. Oliver Klee voted on patch set 2 CR +1 08/31/20, 10:14

  11. Christian Kuhn voted on patch set 2 V +1 CR +1 08/31/20, 11:48

  12. Benni Mack voted on patch set 2 V +2 CR +2 08/31/20, 18:21

  13. Benni Mack merged patch set 3 08/31/20, 18:21