65373[BUGFIX] Handle missing files in ImageService
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
-
Verified V +2 Done
- Daniel Goerz +2
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1318
-
Daniel Goerz commented on patch set 1 08/19/20, 17:53
Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/extbase/Classes/Service/ImageService.php -
TYPO3com voted on patch set 1 V -1 08/19/20, 17:53 Completed build in 26s on Wed, 19 Aug, 05:53 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-244
-
Daniel Goerz uploaded patch set 2 08/19/20, 17:58
-
TYPO3com voted on patch set 2 V +1 08/19/20, 18:09 Completed build in 11m 27s on Wed, 19 Aug, 06:09 PM Test Summary: 74034 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-245
-
Jörg Bösche commented on patch set 2 08/20/20, 08:03
Shouldn't a logging be built in here so that it can be seen which file could not be found? For debugging purposes? I know, it's work in progress. ;-) -
Daniel Goerz commented on patch set 2 08/21/20, 11:53
This change is ready for review. -
Daniel Goerz commented on patch set 2 08/21/20, 11:54
Hi Jörg, logging could be added, but certainly not in a backport ;) -
Daniel Goerz commented on patch set 2 08/21/20, 11:55
ImageService.php:189Hi Markus and Kevin, since the code differs here between mater and v10 I went for this approach, please review and test accordingly as this is a manual backport -
Markus Klein commented on patch set 2 CR +1 08/21/20, 12:01
Still, looks good to me -
Kevin Ditscheid commented on patch set 2 08/21/20, 12:25
ImageService.php:189ReplyMaybe save the publicUrl in a variable and check that for null, instead of calling getPublicUrl twice? -
Daniel Goerz commented on patch set 2 08/21/20, 12:29
ImageService.php:189Reply UnresolvedSounds good, since getPublicUrl() is not a simple getter but actually requires some calculation. Will take care of that -
Daniel Goerz uploaded patch set 3 08/21/20, 12:44
-
Daniel Goerz uploaded patch set 4 08/21/20, 12:45
-
TYPO3com voted on patch set 3 V -1 08/21/20, 12:59 Completed build in 14m 19s on Fri, 21 Aug, 12:59 PM Test Summary: 2 of 74520 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-248
-
TYPO3com voted on patch set 4 V -1 08/21/20, 13:04 Completed build in 14m 50s on Fri, 21 Aug, 01:04 PM Test Summary: 1 of 74519 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-249
-
TYPO3com voted on patch set 4 V +1 08/21/20, 14:21 Completed build in 1h 46m 40s on Fri, 21 Aug, 02:21 PM Test Summary: 74034 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-249
-
Daniel Goerz voted on patch set 4 V +2 CR +2 08/22/20, 11:42
-
Daniel Goerz merged patch set 5 08/22/20, 11:42