Review main Merged

65392[BUGFIX] Fix wrong return hint for getRecordOverlay

Kevin Ditscheid CR +2 V +2 Easy +2 −2 updated 08/21/20, 15:52

Commit message

This commit changes the return hint of
TYPO3\CMS\Core\Domain\Repository\PageRepository::getRecordOverlay to
mention that the function returns NULL instead of FALSE, if
$OLmode is "hideNonTranslated" and no translation is found

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 57

  1. Kevin Ditscheid uploaded patch set 1 08/20/20, 08:35

  2. Kevin Ditscheid updated the commit message in patch set 2 08/20/20, 08:36

  3. TYPO3com voted on patch set 1 V +1 08/20/20, 08:48 Completed build in 12m 35s on Thu, 20 Aug, 08:48 AM Test Summary: 72996 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4777

  4. TYPO3com voted on patch set 2 V +1 08/20/20, 08:50 Completed build in 13m 56s on Thu, 20 Aug, 08:50 AM Test Summary: 72996 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4778

  5. Christian Kuhn voted on patch set 2 V +1 CR +1 08/21/20, 15:50

  6. Andreas Kienast voted on patch set 2 V +2 CR +2 08/21/20, 15:52

  7. Andreas Kienast merged patch set 3 08/21/20, 15:52