Review main Merged

65393[TASK] Merge DeletedRecordsController into RecyclerAjaxController

Christian Kuhn CR +2 V +2 Hard +158 −230 updated 08/21/20, 14:22

Commit message

In extension 'recycler', the DeletedRecordsController is only
used from within the RecyclerAjaxController. Controller calling
other controllers this way is bad code smell.
The patch merges the transform() method together with its
helper methods into the RecyclerAjaxController and applies
minor cleanups to the class along the way.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1215

  1. Christian Kuhn uploaded patch set 1 08/20/20, 12:09

  2. TYPO3com voted on patch set 1 V +1 08/20/20, 12:21 Completed build in 11m 02s on Thu, 20 Aug, 12:21 PM Test Summary: 72996 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4779

  3. Andreas Kienast voted on patch set 1 CR +1 08/20/20, 16:29

  4. Daniel Windloff voted on patch set 1 V +1 CR +1 08/21/20, 07:30

  5. Achim Fritz voted on patch set 1 V +1 CR +1 08/21/20, 07:42

  6. Andreas Kienast uploaded patch set 2 08/21/20, 12:07

  7. Andreas Kienast voted on patch set 2 V +1 CR +1 08/21/20, 12:07

  8. TYPO3com voted on patch set 2 V +1 08/21/20, 12:19 Completed build in 11m 52s on Fri, 21 Aug, 12:19 PM Test Summary: 72996 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4797

  9. Daniel Goerz commented on patch set 2 08/21/20, 12:19

    RecyclerAjaxController.php:176 Unresolved

    Whats a JSON Array? We can get rid of the annotations and type hint the argument as array $deletedRowsArray

    RecyclerAjaxController.php:223 Unresolved

    int $pageId and remove annotations

    RecyclerAjaxController.php:244 Unresolved

    Superfluous annotations

    RecyclerAjaxController.php:273 Unresolved

    Superfluous annotations

    RecyclerAjaxController.php:321 Unresolved

    Superfluous doc block

    RecyclerAjaxController.php:331 Unresolved

    Superfluous doc block
  10. Andreas Kienast uploaded patch set 3 08/21/20, 12:22

  11. Daniel Goerz voted on patch set 3 CR +1 08/21/20, 12:37

  12. TYPO3com voted on patch set 3 V +1 08/21/20, 12:38 Completed build in 13m 40s on Fri, 21 Aug, 12:38 PM Test Summary: 72996 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4799

  13. Andreas Kienast voted on patch set 3 V +1 CR +1 08/21/20, 13:07

  14. Daniel Goerz voted on patch set 3 V +2 CR +2 08/21/20, 14:22

  15. Daniel Goerz merged patch set 4 08/21/20, 14:22