Review main Merged

65395[BUGFIX] Adjust CSS import paths in inline CSS

Alexander Künzl CR +2 V +2 Hard +198 −53 updated 09/14/20, 12:50

Commit message

Extracts CSS path fixing functionality of ResourceCompressor
to a separate class in order to be used in other contexts.
PageRenderer uses the new object.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1017

  1. Alexander Künzl uploaded patch set 1 08/20/20, 13:28

  2. TYPO3com voted on patch set 1 V -1 08/20/20, 13:29 Completed build in 26s on Thu, 20 Aug, 01:29 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4781

  3. Alexander Künzl uploaded patch set 2 08/21/20, 05:48

  4. TYPO3com voted on patch set 2 V -1 08/21/20, 06:08 Completed build in 19m 54s on Fri, 21 Aug, 06:08 AM Test Summary: 72044 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4787

  5. TYPO3com voted on patch set 2 V +1 08/21/20, 08:21 Completed build in 11m 06s on Fri, 21 Aug, 08:21 AM Test Summary: 73026 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4791

  6. Andreas Kienast uploaded patch set 3 08/21/20, 16:31

  7. TYPO3com voted on patch set 3 V +1 08/21/20, 16:44 Completed build in 12m 37s on Fri, 21 Aug, 04:44 PM Test Summary: 73024 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4822

  8. Jörg Bösche commented on patch set 3 CR -1 08/25/20, 11:21

    PageRenderer.php:2522 Unresolved

    Please add a return type to the method. -> getPathFixer(): PathFixer

    ResourceCompressor.php:216 Unresolved

    Please add a return type to the method. -> getPathFixer(): PathFixer

    ResourceCompressor.php:519 Unresolved

    Please add a return type to the method. -> cssFixRelativeUrlPaths(): string

    PathFixerTest.php:33 Unresolved

    Are you sure that we need all of the definitions? IMO only one declaration from PathFixer is required. - See setUp().
  9. Alexander Künzl uploaded patch set 4 08/27/20, 12:19

  10. TYPO3com voted on patch set 4 V -1 08/27/20, 12:31 Completed build in 11m 26s on Thu, 27 Aug, 12:30 PM Test Summary: 2 of 73607 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5008

  11. TYPO3com voted on patch set 4 V +1 08/27/20, 12:58 Completed build in 10m 47s on Thu, 27 Aug, 12:58 PM Test Summary: 73122 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5012

  12. Benni Mack uploaded patch set 5 09/12/20, 18:58

  13. Benni Mack voted on patch set 5 CR +1 09/12/20, 18:58

  14. TYPO3com voted on patch set 5 V +1 09/12/20, 19:14 Completed build in 14m 09s on Sat, 12 Sep, 07:14 PM Test Summary: 73239 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5565

  15. Oli Bartsch voted on patch set 5 V +1 CR +1 09/14/20, 12:27

  16. Benni Mack voted on patch set 5 V +2 CR +2 09/14/20, 12:50

  17. Benni Mack merged patch set 6 09/14/20, 12:50