65395[BUGFIX] Adjust CSS import paths in inline CSS
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- TYPO3com +1 CI
Issues 1
Files 4
Review log 1017
-
Alexander Künzl uploaded patch set 1 08/20/20, 13:28
-
TYPO3com voted on patch set 1 V -1 08/20/20, 13:29 Completed build in 26s on Thu, 20 Aug, 01:29 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4781
-
Alexander Künzl uploaded patch set 2 08/21/20, 05:48
-
TYPO3com voted on patch set 2 V -1 08/21/20, 06:08 Completed build in 19m 54s on Fri, 21 Aug, 06:08 AM Test Summary: 72044 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4787
-
TYPO3com voted on patch set 2 V +1 08/21/20, 08:21 Completed build in 11m 06s on Fri, 21 Aug, 08:21 AM Test Summary: 73026 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4791
-
Andreas Kienast uploaded patch set 3 08/21/20, 16:31
-
TYPO3com voted on patch set 3 V +1 08/21/20, 16:44 Completed build in 12m 37s on Fri, 21 Aug, 04:44 PM Test Summary: 73024 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4822
-
Jörg Bösche commented on patch set 3 CR -1 08/25/20, 11:21
ResourceCompressor.php:216UnresolvedPlease add a return type to the method. -> getPathFixer(): PathFixerResourceCompressor.php:519UnresolvedPlease add a return type to the method. -> cssFixRelativeUrlPaths(): stringPathFixerTest.php:33UnresolvedAre you sure that we need all of the definitions? IMO only one declaration from PathFixer is required. - See setUp(). -
Alexander Künzl uploaded patch set 4 08/27/20, 12:19
-
TYPO3com voted on patch set 4 V -1 08/27/20, 12:31 Completed build in 11m 26s on Thu, 27 Aug, 12:30 PM Test Summary: 2 of 73607 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5008
-
TYPO3com voted on patch set 4 V +1 08/27/20, 12:58 Completed build in 10m 47s on Thu, 27 Aug, 12:58 PM Test Summary: 73122 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5012
-
Benni Mack uploaded patch set 5 09/12/20, 18:58
-
Benni Mack voted on patch set 5 CR +1 09/12/20, 18:58
-
TYPO3com voted on patch set 5 V +1 09/12/20, 19:14 Completed build in 14m 09s on Sat, 12 Sep, 07:14 PM Test Summary: 73239 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5565
-
Oli Bartsch voted on patch set 5 V +1 CR +1 09/14/20, 12:27
-
Benni Mack voted on patch set 5 V +2 CR +2 09/14/20, 12:50
-
Benni Mack merged patch set 6 09/14/20, 12:50
PageRenderer.php:2522Unresolved