Review main Merged Breaking

65397[!!!][TASK] Drop unused TYPO3\CMS\Backend\View\PageTreeView

Christian Kuhn CR +2 V +2 Hard +41 −319 updated 08/21/20, 15:18

Commit message

The class seems to be unused for a while. Drop without
substitution. Don't confuse this removal with class
TYPO3\CMS\Backend\Tree\View\PageTreeView.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Daniel Windloff +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Daniel Windloff +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1215

  1. Christian Kuhn uploaded patch set 1 08/20/20, 18:11

  2. TYPO3com voted on patch set 1 V +1 08/20/20, 18:22 Completed build in 10m 50s on Thu, 20 Aug, 06:22 PM Test Summary: 72994 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4783

  3. Georg Ringer commented on patch set 1 CR -1 08/20/20, 19:32

    pls still mention in the rst and mark this as breaking. there is also nothing wrong with adding it to the extension scanner
  4. Christian Kuhn commented on patch set 1 08/20/20, 21:01

    The class is marked internal, so I thought a .rst for an outdated and unused class wouldn't be needed as it adds little value. I will still add it as requested, it's not a problem in this case.
  5. Daniel Windloff voted on patch set 1 V +1 CR +1 08/21/20, 07:50

  6. Christian Kuhn uploaded patch set 2 08/21/20, 13:27

  7. Daniel Windloff voted on patch set 2 V +1 CR +1 08/21/20, 13:33

  8. TYPO3com voted on patch set 2 V -1 08/21/20, 13:38 Completed build in 10m 41s on Fri, 21 Aug, 01:38 PM Test Summary: 72995 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4805

  9. Christian Kuhn uploaded patch set 3 08/21/20, 13:55

  10. Daniel Windloff voted on patch set 3 V +1 CR +1 08/21/20, 13:58

  11. TYPO3com voted on patch set 3 V +1 08/21/20, 14:06 Completed build in 10m 40s on Fri, 21 Aug, 02:06 PM Test Summary: 72996 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4806

  12. Andreas Kienast commented on patch set 3 08/21/20, 14:24

    Technically this isn't breaking as the class is marked as internal ;)
  13. Andreas Kienast voted on patch set 3 CR +1 08/21/20, 14:25

  14. Andreas Kienast voted on patch set 3 V +2 CR +2 08/21/20, 15:17

  15. Andreas Kienast merged patch set 4 08/21/20, 15:18