Review main Merged

65398[BUGFIX] Respect defaultAction for file overrides set in UserTSconfig

Kevin Appelt CR +2 V +2 Easy +3 −3 updated 08/22/20, 11:36

Commit message

So far always the SKIP action was executed. But in the drop-down of the
actions the correct option was already selected. Now the default action
is also executed and not only displayed.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Kevin Appelt +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Kevin Appelt +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 69

  1. Kevin Appelt uploaded patch set 1 08/21/20, 05:37

  2. Andreas Kienast commented on patch set 1 CR -1 08/21/20, 05:39

    on it

    DragUploader.ts:101 Unresolved

    Make this a type of `Action` instead.
  3. Andreas Kienast uploaded patch set 2 08/21/20, 05:40

  4. TYPO3com voted on patch set 1 V -1 08/21/20, 05:54 Completed build in 17m 03s on Fri, 21 Aug, 05:54 AM Test Summary: 29 of 73483 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4784

  5. TYPO3com voted on patch set 2 V -1 08/21/20, 06:04 Completed build in 16m 57s on Fri, 21 Aug, 06:04 AM Test Summary: 2 of 73483 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4786

  6. TYPO3com voted on patch set 2 V +1 08/21/20, 06:14 Completed build in 43m 35s on Fri, 21 Aug, 06:14 AM Test Summary: 72996 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4786

  7. Kevin Appelt voted on patch set 2 V +1 CR +1 08/21/20, 06:14

  8. Daniel Goerz voted on patch set 2 V +2 CR +2 08/22/20, 11:36

  9. Daniel Goerz merged patch set 3 08/22/20, 11:36