Review main Merged

65399[BUGFIX] DatabaseRecordList constructor

Daniel Windloff CR +2 V +2 Easy +2 −18 updated 08/21/20, 12:12

Commit message

- Set translateTools without wrapper method
- Remove the unnecessarily duplicate IconFactory

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 58

  1. Daniel Windloff uploaded patch set 1 08/21/20, 05:38

  2. TYPO3com voted on patch set 1 V -1 08/21/20, 06:02 Completed build in 24m 06s on Fri, 21 Aug, 06:02 AM Test Summary: 1 of 72173 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4785

  3. TYPO3com voted on patch set 1 V +1 08/21/20, 06:20 Completed build in 12m 03s on Fri, 21 Aug, 06:20 AM Test Summary: 72996 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4788

  4. Christian Kuhn updated the commit message in patch set 2 08/21/20, 10:58

  5. Christian Kuhn voted on patch set 2 V +1 CR +1 08/21/20, 10:58

  6. TYPO3com voted on patch set 2 V +1 08/21/20, 11:09 Completed build in 11m 18s on Fri, 21 Aug, 11:09 AM Test Summary: 72996 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4793

  7. Daniel Goerz voted on patch set 2 V +2 CR +2 08/21/20, 12:12

  8. Daniel Goerz merged patch set 3 08/21/20, 12:12