65401[TASK] Migrate RecordListController hooks to an PSR-14 event
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Christian Kuhn +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 1
Files 10
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-92062-MigrateRecordListControllerHooksToAnPSR-14Event.rstnew+64 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ArrayDimensionMatcher.php+10 −0
- typo3/sysext/recordlist/Classes/Controller/RecordListController.php+15 −18
- typo3/sysext/recordlist/Classes/Event/RenderAdditionalContentToRecordListEvent.phpnew+64 −0
- typo3/sysext/recordlist/Classes/HookProvider/AddToRecordListHookProvider.phpnew+52 −0
- typo3/sysext/recordlist/Configuration/Services.yaml+7 −0
- typo3/sysext/sys_note/Classes/Hook/RecordListHook.phpdeleted+0 −60
- typo3/sysext/sys_note/Classes/Provider/RecordListProvider.phpnew+43 −0
- typo3/sysext/sys_note/Configuration/Services.yaml+5 −0
- typo3/sysext/sys_note/ext_localconf.php+0 −3
Review log 1217
-
Daniel Windloff uploaded patch set 1 08/21/20, 07:02
-
TYPO3com voted on patch set 1 V +1 08/21/20, 07:13 Completed build in 10m 32s on Fri, 21 Aug, 07:13 AM Test Summary: 72996 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4790
-
Christian Kuhn commented on patch set 1 08/21/20, 11:11
I like that on reading already but would love to have an opinion on the strategy by benni, too. -
Christian Kuhn commented on patch set 1 CR -1 08/21/20, 11:14
-1 for now, will take care to get more feedback. -
Daniel Windloff uploaded patch set 2 08/26/20, 06:48
-
TYPO3com voted on patch set 2 V +1 08/26/20, 06:59 Completed build in 11m 01s on Wed, 26 Aug, 06:59 AM Test Summary: 73092 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4971
-
Christian Kuhn commented on patch set 2 08/29/20, 11:41
General +1, one detail: The ArrayDimensionMatcher of the extension scanner could look for the hook array to find usages. This can be mentioned in the .rst file. -
Daniel Windloff uploaded patch set 3 08/30/20, 08:27
-
TYPO3com voted on patch set 3 V +1 08/30/20, 08:40 Completed build in 12m 07s on Sun, 30 Aug, 08:40 AM Test Summary: 73092 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5049
-
Christian Kuhn voted on patch set 3 V +1 CR +1 08/30/20, 10:45
-
Christian Kuhn uploaded patch set 4 08/30/20, 15:01
-
TYPO3com voted on patch set 4 V -1 08/30/20, 15:03 Completed build in 22s on Sun, 30 Aug, 03:03 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5060
-
Christian Kuhn uploaded patch set 5 08/30/20, 15:08
-
Christian Kuhn voted on patch set 5 V +1 CR +1 08/30/20, 15:11
-
TYPO3com voted on patch set 5 V +1 08/30/20, 15:25 Completed build in 13m 59s on Sun, 30 Aug, 03:25 PM Test Summary: 73146 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5062
-
Anja Leichsenring voted on patch set 5 V +2 CR +2 08/30/20, 15:29
-
Anja Leichsenring merged patch set 6 08/30/20, 15:29