Review main Merged

65402[TASK] DatabaseRecordList: Unify place for table related queries

Daniel Windloff CR +2 V +2 Hard +102 −161 updated 12/17/21, 11:37

Commit message

Move table related query parts to getQueryBuilder:
* Move the hook "getTable" to getQueryBuilder
* Move query constraints from getTable to getQueryBuilder
* Set field list as parameter to getQueryBuilder
* Set limit, offset, addSorting as add. parameters to getQueryBuilder
* Move code from prepareQueryBuilder to getQueryBuilder

Related to the usage of getQueryBuilder:
* Use getQueryBuilder to calculate if a table has any result.
* Use getQueryBuilder to calculate the total number of hits.

Move getSearchString to makeSearchString.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1117

  1. Daniel Windloff uploaded patch set 1 08/21/20, 10:19

  2. TYPO3com voted on patch set 1 V -1 08/21/20, 10:20 Completed build in 25s on Fri, 21 Aug, 10:20 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4792

  3. Daniel Windloff uploaded patch set 2 08/21/20, 12:50

  4. TYPO3com voted on patch set 2 V -1 08/21/20, 13:12 Completed build in 18m 38s on Fri, 21 Aug, 01:12 PM Test Summary: 72667 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4802

  5. TYPO3com voted on patch set 2 V +1 08/21/20, 13:28 Completed build in 10m 54s on Fri, 21 Aug, 01:28 PM Test Summary: 72996 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4804

  6. Daniel Windloff uploaded patch set 3 08/21/20, 14:53

  7. Christian Kuhn voted on patch set 3 V +1 CR +1 08/21/20, 15:00

  8. TYPO3com voted on patch set 3 V +1 08/21/20, 15:07 Completed build in 13m 49s on Fri, 21 Aug, 03:07 PM Test Summary: 72996 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4808

  9. Andreas Kienast uploaded patch set 4 08/21/20, 15:39

  10. Andreas Kienast voted on patch set 4 V +1 CR +1 08/21/20, 15:39

  11. Christian Kuhn voted on patch set 4 V +1 CR +1 08/21/20, 15:42

  12. TYPO3com voted on patch set 4 V -1 08/21/20, 15:51 Completed build in 12m 10s on Fri, 21 Aug, 03:51 PM Test Summary: 6 of 73481 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4816

  13. TYPO3com voted on patch set 4 V +1 08/21/20, 15:59 Completed build in 32m 33s on Fri, 21 Aug, 03:59 PM Test Summary: 72996 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4816

  14. Andreas Kienast voted on patch set 4 V +2 CR +2 08/21/20, 16:00

  15. Andreas Kienast merged patch set 5 08/21/20, 16:00

  16. Benni Mack commented on patch set 5 12/17/21, 11:36

    DatabaseRecordList.php:3108

    thats a regression, as this needs to be without []
  17. Oli Bartsch commented on patch set 5 12/17/21, 11:37

    DatabaseRecordList.php:3108 Reply Unresolved