Review main Merged

65404[TASK] Use named export of MessageUtility in Scheduler.ts

Benjamin Franzke CR +2 V +2 Easy +2 −2 updated 08/21/20, 14:30

Commit message

`import = require('…')` should only be used when
the required module exports via the respective `export =`
instruction.

As MessageUtility exports only one named export
(called `MessageUtility`), we should import
via ES6 named import syntax.

Note: Technically (in the generated source) this change
makes no difference, as the named export was available
as property of the AMD export-object, and therefore
`import = ` worked.

Therefore there are no changes to the generated files when executing:

  grunt build

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 56

  1. Benjamin Franzke uploaded patch set 1 08/21/20, 11:31

  2. Benjamin Franzke wrote 08/21/20, 11:32

    Topic set to javascript
  3. TYPO3com voted on patch set 1 V +1 08/21/20, 11:47 Completed build in 15m 20s on Fri, 21 Aug, 11:47 AM Test Summary: 72996 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4795

  4. Andreas Kienast voted on patch set 1 V +1 CR +1 08/21/20, 12:37

  5. Daniel Goerz voted on patch set 1 V +2 CR +2 08/21/20, 14:30

  6. Daniel Goerz merged patch set 2 08/21/20, 14:30