Review main Merged

65406[BUGFIX] Page tree: Hide delete drop zone when not dragging

Helmut Hummel CR +2 V +2 Easy +11 −5 updated 09/20/20, 06:52

Commit message

Once a page is selected in the page tree,
a drag action is initiated and a drop zone created
for a delete action on the current page.

But since the drag is immediately stopped,
without a dragging action, it is necessary
to always delete this created dropzone,
to avoid that it is created multiple times.

To avoid additional flickering of the focus
indicator, when selecting a page, the drop zone
is hidden by CSS until the page is actually
dragged on itself and the dropzone is shown.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Daniel Goerz +1
    • Jörg Bösche +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1519

  1. Helmut Hummel uploaded patch set 1 08/21/20, 14:43

  2. TYPO3com voted on patch set 1 V +1 08/21/20, 14:54 Completed build in 11m 11s on Fri, 21 Aug, 02:54 PM Test Summary: 72996 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4807

  3. Simon Gilli updated the commit message in patch set 2 08/21/20, 15:07

  4. TYPO3com voted on patch set 2 V +1 08/21/20, 15:22 Completed build in 14m 56s on Fri, 21 Aug, 03:22 PM Test Summary: 72996 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4812

  5. Markus Klein commented on patch set 2 08/21/20, 15:31

    PageTreeDragDrop.js:131

    .dataset.open = false wouldn't that be the right way to modify data for a node?
  6. Andreas Kienast commented on patch set 2 08/21/20, 16:15

    PageTreeDragDrop.js:131 Reply

    AFAIK this is d3 related code.
  7. Andreas Kienast voted on patch set 2 V +1 CR +1 08/21/20, 16:26

  8. Helmut Hummel commented on patch set 2 08/21/20, 19:05

    PageTreeDragDrop.js:131 Reply

    yes exactly. Besides that, it's done this way in this code already. I just added it to the initialization as well
  9. Helmut Hummel uploaded patch set 3 08/27/20, 13:25

  10. Helmut Hummel commented on patch set 3 08/27/20, 13:26

    rebuilt backend css only
  11. TYPO3com voted on patch set 3 V +1 08/27/20, 13:37 Completed build in 11m 07s on Thu, 27 Aug, 01:37 PM Test Summary: 73092 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5013

  12. Andreas Kienast voted on patch set 3 V +1 CR +1 08/27/20, 14:02

  13. Andreas Kienast uploaded patch set 4 08/28/20, 13:11

  14. Andreas Kienast voted on patch set 4 V +1 CR +1 08/28/20, 13:11

  15. TYPO3com voted on patch set 4 V +1 08/28/20, 13:25 Completed build in 14m 40s on Fri, 28 Aug, 01:25 PM Test Summary: 73092 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5032

  16. Jörg Bösche voted on patch set 4 CR +1 09/07/20, 08:10

  17. Daniel Goerz voted on patch set 4 V +1 CR +1 09/19/20, 12:34

  18. Andreas Kienast voted on patch set 4 V +2 CR +2 09/20/20, 06:52

  19. Andreas Kienast merged patch set 5 09/20/20, 06:52