Review main Merged

65408[TASK] Drop SOBE from EditDocumentController

Christian Kuhn CR +2 V +2 Easy +2 −8 updated 08/22/20, 09:54

Commit message

The $GLOBALS['SOBE'] = $this; assignment has been kept in
EditDocumentController together with two public properties
to keep an old working version of the ConditionMatcher.
This has been resolved meanwhile, the code can be dropped.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Björn Jacob +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Björn Jacob +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 45

  1. Christian Kuhn uploaded patch set 1 08/21/20, 21:46

  2. TYPO3com voted on patch set 1 V +1 08/21/20, 21:58 Completed build in 12m 10s on Fri, 21 Aug, 09:58 PM Test Summary: 72996 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4827

  3. Björn Jacob voted on patch set 1 V +1 CR +1 08/22/20, 06:14

  4. Andreas Kienast voted on patch set 1 V +2 CR +2 08/22/20, 09:54

  5. Andreas Kienast merged patch set 2 08/22/20, 09:54