Review main Merged

65410[TASK] DatabaseRecordList: Drop unnecessary DB-Query for each table

Daniel Windloff CR +2 V +2 Easy +9 −13 updated 08/22/20, 09:40

Commit message

For each TCA table a query to determine if a result exists is made.
It could have been some kind of performance optimization,
but it results in an additional query for each table with records
in place.

Such optimizations should be done in the getTable method by using the
existing query to count the total number of records of the table.
Therefore, the query result (the total number of records of the table)
has been used for a guard clause.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 46

  1. Daniel Windloff uploaded patch set 1 08/22/20, 05:53

  2. TYPO3com voted on patch set 1 V -1 08/22/20, 06:26 Completed build in 33m 15s on Sat, 22 Aug, 06:26 AM Test Summary: 62 of 73482 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4833

  3. TYPO3com voted on patch set 1 V +1 08/22/20, 07:01 Completed build in 15m 05s on Sat, 22 Aug, 07:01 AM Test Summary: 72995 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4837

  4. Christian Kuhn commented on patch set 1 V +1 CR +1 08/22/20, 09:01

    nice. first refactoring fruit :)
  5. Andreas Kienast voted on patch set 1 V +2 CR +2 08/22/20, 09:40

  6. Andreas Kienast merged patch set 2 08/22/20, 09:40