Review 10.4 Merged

65415[TASK] Use named export of MessageUtility in Scheduler.ts

Daniel Goerz CR +2 V +2 Easy +2 −2 updated 08/22/20, 16:38

Commit message

`import = require('…')` should only be used when
the required module exports via the respective `export =`
instruction.

As MessageUtility exports only one named export
(called `MessageUtility`), we should import
via ES6 named import syntax.

Note: Technically (in the generated source) this change
makes no difference, as the named export was available
as property of the AMD export-object, and therefore
`import = ` worked.

Therefore there are no changes to the generated files when executing:

  grunt build

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Daniel Goerz commented on patch set 1 08/21/20, 14:30

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 08/21/20, 14:42 Completed build in 11m 38s on Fri, 21 Aug, 02:42 PM Test Summary: 74034 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-250

  3. Benjamin Franzke voted on patch set 1 V +2 CR +2 08/22/20, 16:38

  4. Benjamin Franzke merged patch set 2 08/22/20, 16:38