Review 10.4 Merged

65420[BUGFIX] Make edit record bookmarks appear again

Andreas Kienast CR +2 V +2 Easy +2 −1 updated 08/22/20, 09:27

Commit message

The patch for issue #91210 introduced a side effect that bookmarks
to controllers which are not directly registered as backend modules
do not show up again because the ModuleLoader->checkMod() call does
not return an array anymore.
Bookmarks to records of FormEngine / EditDocumentController
are affected by this and are simply not rendered as bookmark
toolbar items.
The patch applies a hack to the ShortcutRepository to deal with
this. We need a better module / controller access API substituting
TBE_MODULES to deal with this properly. EditDocumentController
does it's own access checks for records, so the patch shouldn't
add security harm.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 35

  1. Andreas Kienast commented on patch set 1 08/22/20, 09:04

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V -1 08/22/20, 09:18 Completed build in 13m 59s on Sat, 22 Aug, 09:18 AM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-256

  3. TYPO3com voted on patch set 1 V +1 08/22/20, 09:27 Completed build in 36m 19s on Sat, 22 Aug, 09:27 AM Test Summary: 74034 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-256

  4. Andreas Kienast voted on patch set 1 V +2 CR +2 08/22/20, 09:27

  5. Andreas Kienast merged patch set 2 08/22/20, 09:27