Review 10.4 Merged

65423[BUGFIX] Ensure correct loading order in ModuleTemplate

Daniel Goerz CR +2 V +2 Easy +6 −6 updated 08/22/20, 12:37

Commit message

This change makes sure to set up the page in the TYPO3 Backend,
to load JS and CSS directly in PageRenderer when the ModuleTemplate
object is instantiated, allowing to load custom JavaScript or CSS.

Before, renderContent (the last call in ModuleTemplate) was
used to add default CSS and JS.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
  • Verified V +2 Done
    • Daniel Goerz +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 35

  1. Daniel Goerz commented on patch set 1 08/22/20, 11:47

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V -1 08/22/20, 12:00 Completed build in 12m 14s on Sat, 22 Aug, 12:00 PM Test Summary: 73515 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-261

  3. TYPO3com voted on patch set 1 V +1 08/22/20, 12:08 Completed build in 32m 42s on Sat, 22 Aug, 12:08 PM Test Summary: 74034 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-261

  4. Daniel Goerz voted on patch set 1 V +2 CR +2 08/22/20, 12:37

  5. Daniel Goerz merged patch set 2 08/22/20, 12:37