65428[BUGFIX] Discarding record in workspaces deletes move placeholder
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
-
Verified V +2 Done
- Anja Leichsenring +2
- TYPO3com +1 CI
Issues 1
Files 15
- typo3/sysext/core/Tests/Functional/DataHandling/IRRE/CSV/AbstractActionTestCase.php+1 −0
- typo3/sysext/workspaces/Classes/Hook/DataHandlerHook.php+78 −26
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/Modify/DataSet/moveParentContentToDifferentPageAndDiscard.csvnew+32 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/Modify/DataSet/moveParentContentToDifferentPageAndDiscardWithoutSoftDelete.csvnew+33 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/Modify/ActionTest.php+28 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/AbstractActionTestCase.php+22 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/Modify/DataSet/moveParentContentToDifferentPageAndDiscard.csvnew+36 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/Modify/DataSet/moveParentContentToDifferentPageAndDiscardWithoutSoftDelete.csvnew+34 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/Modify/ActionTest.php+28 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/AbstractActionTestCase.php+22 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Modify/DataSet/moveContentToDifferentPageAndDiscard.csvnew+15 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Modify/DataSet/moveContentToDifferentPageAndDiscardWithoutSoftDelete.csvnew+13 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Modify/ActionTest.php+28 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/AbstractActionTestCase.php+19 −0
- typo3/sysext/workspaces/Tests/Functional/Hook/DataSet/deletingSysWorkspaceDeletesWorkspaceRecordsResult.csv+0 −4
Review log 711
-
Anja Leichsenring commented on patch set 1 08/25/20, 17:08
Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/workspaces/Classes/Hook/DataHandlerHook.php -
Anja Leichsenring commented on patch set 1 08/25/20, 17:08
This change is ready for review. -
Anja Leichsenring commented on patch set 1 CR -1 08/25/20, 17:09
not ready, we will take care later. -
TYPO3com voted on patch set 1 V -1 08/25/20, 17:09 Completed build in 26s on Tue, 25 Aug, 05:09 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-266
-
Christian Kuhn commented on patch set 1 CR -1 08/25/20, 17:09
will resolve the conflict tomorrow -
Christian Kuhn uploaded patch set 2 08/26/20, 12:49
-
TYPO3com voted on patch set 2 V -1 08/26/20, 13:29 Completed build in 39m 48s on Wed, 26 Aug, 01:29 PM Test Summary: 7 of 72777 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-278
-
TYPO3com commented on patch set 2 08/26/20, 13:51 Completed build in 1h 41m 19s on Wed, 26 Aug, 01:51 PM Test Summary: 1 of 74546 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-278
-
TYPO3com voted on patch set 2 V +1 08/27/20, 07:56 Completed build in 20h 48m 10s on Thu, 27 Aug, 07:56 AM Test Summary: 74061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-278
-
Anja Leichsenring voted on patch set 2 V +2 CR +2 08/27/20, 08:02
-
Anja Leichsenring merged patch set 3 08/27/20, 08:03