Review 10.4 Merged

65428[BUGFIX] Discarding record in workspaces deletes move placeholder

Anja Leichsenring CR +2 V +2 Hard +389 −30 updated 08/27/20, 08:03

Commit message

When discarding a workspace change of a record that has been
moved, the move-to-pointer (t3ver_state=3) is not set to
deleted=1 as it should. This leads to issues, for instance
the list module shows the records twice.
The patch partially fixes this behavior: For top-level
records, move pointer are now properly deleted as shown
by Regular/Modify test moveContentToDifferentPageAndDiscard
for a 'discard' case, and for a 'flush' related test case
in existing deletingSysWorkspaceDeletesWorkspaceRecordsResult,
which removes two todos.
For relations, the issue is harder to tackle, for now
coverage is added for inline csv and foreignField, to nail
with @todos that delete cascading of move pointer records is
still troublesome.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
  • Verified V +2 Done
    • Anja Leichsenring +2
    • TYPO3com +1 CI

Issues 1

Files 15

Review log 711

  1. Anja Leichsenring commented on patch set 1 08/25/20, 17:08

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/workspaces/Classes/Hook/DataHandlerHook.php
  2. Anja Leichsenring commented on patch set 1 08/25/20, 17:08

    This change is ready for review.
  3. Anja Leichsenring commented on patch set 1 CR -1 08/25/20, 17:09

    not ready, we will take care later.
  4. TYPO3com voted on patch set 1 V -1 08/25/20, 17:09 Completed build in 26s on Tue, 25 Aug, 05:09 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-266

  5. Christian Kuhn commented on patch set 1 CR -1 08/25/20, 17:09

    will resolve the conflict tomorrow
  6. Christian Kuhn uploaded patch set 2 08/26/20, 12:49

  7. TYPO3com voted on patch set 2 V -1 08/26/20, 13:29 Completed build in 39m 48s on Wed, 26 Aug, 01:29 PM Test Summary: 7 of 72777 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-278

  8. TYPO3com commented on patch set 2 08/26/20, 13:51 Completed build in 1h 41m 19s on Wed, 26 Aug, 01:51 PM Test Summary: 1 of 74546 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-278

  9. TYPO3com voted on patch set 2 V +1 08/27/20, 07:56 Completed build in 20h 48m 10s on Thu, 27 Aug, 07:56 AM Test Summary: 74061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-278

  10. Anja Leichsenring voted on patch set 2 V +2 CR +2 08/27/20, 08:02

  11. Anja Leichsenring merged patch set 3 08/27/20, 08:03