Review 10.4 Merged

65429[BUGFIX] Fix unique slug when counter suffix fails

Anja Leichsenring CR +2 V +2 Hard +251 −38 updated 08/25/20, 17:33

Commit message

A loop in the Slug "uniqueIn*" check is broken because
the comparison uses post-increment, and in case no valid
slug with a counter suffix is found, $counter will be 101,
not 100.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
  • Verified V +2 Done
    • Anja Leichsenring +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 34

  1. Anja Leichsenring commented on patch set 1 08/25/20, 17:20

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 08/25/20, 17:33 Completed build in 11m 58s on Tue, 25 Aug, 05:33 PM Test Summary: 74043 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-267

  3. Anja Leichsenring voted on patch set 1 V +2 CR +2 08/25/20, 17:33

  4. Anja Leichsenring merged patch set 2 08/25/20, 17:33