Review main Merged

65439[BUGFIX] DB check -> full search shows deleted records if requested

Christian Kuhn CR +2 V +2 Easy +15 −18 updated 08/24/20, 17:33

Commit message

With #82729 the $GLOBALS['SOBE'] = $this; assignment in
DatabaseIntegrityController has been removed. This is a
good thing, however parts of QueryGenerator class still
relied on this.
The patch gives the module settings that have been
introduced for #83428 from QueryView down to
QueryGenerator as well.
This fixes a couple of details, most importantly the
'Show even deleted entries' checkbox of the full search
advanced query view works again.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 3

Files 2

Review log 57

  1. Christian Kuhn uploaded patch set 1 08/23/20, 14:19

  2. Christian Kuhn commented on patch set 1 08/23/20, 14:22

    QueryGenerator.php:1495 Unresolved

    0 is ok here: it's done like that at other places in the class already, and the module is never shown in page tree context anyway.

    QueryGenerator.php:1508 Unresolved

    0 is ok here: it's done like that at other places in the class already, and the module is never shown in page tree context anyway.
  3. TYPO3com voted on patch set 1 V -1 08/23/20, 14:30 Completed build in 10m 51s on Sun, 23 Aug, 02:30 PM Test Summary: 72759 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4872

  4. TYPO3com voted on patch set 1 V +1 08/23/20, 17:17 Completed build in 3h 08m 53s on Sun, 23 Aug, 05:17 PM Test Summary: 73074 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4872

  5. Anja Leichsenring voted on patch set 1 V +1 CR +1 08/23/20, 17:21

  6. Andreas Kienast voted on patch set 1 V +2 CR +2 08/24/20, 17:33

  7. Andreas Kienast merged patch set 2 08/24/20, 17:33