Review main Merged

65440[TASK] Deprecate 3rd party usages of getTreeList() in QueryGenerator and QueryView

Christian Kuhn CR +2 V +2 Hard +197 −96 updated 08/25/20, 17:10

Commit message

The nearly identical methods getTreeList() of core classes
QueryGenerator and QueryView are standalone methods that do
not depend on further state of those classes.
Those classes mostly belong to the ext:lowlevel
DatabaseIntegrityController as their main jobs.
To allow further refactoring of them, the patch drops 3rd party
usages in ext:extbase and ext:workspaces, and protects the methods
in a backwards compatible way.
The new implementations are slightly more effective by skipping
string implode/explode operations.
The extbase change is accompanied by a new functional test to
drop two heavy mocking unit tests.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 9

Review log 1522

  1. Christian Kuhn uploaded patch set 1 08/23/20, 16:28

  2. TYPO3com voted on patch set 1 V +1 08/23/20, 16:39 Completed build in 11m 10s on Sun, 23 Aug, 04:39 PM Test Summary: 73072 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4874

  3. Christian Kuhn uploaded patch set 2 08/23/20, 17:14

  4. TYPO3com voted on patch set 2 V -1 08/23/20, 17:14 Completed build in 25s on Sun, 23 Aug, 05:14 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4876

  5. Christian Kuhn uploaded patch set 3 08/23/20, 17:43

  6. TYPO3com voted on patch set 3 V -1 08/23/20, 17:44 Completed build in 25s on Sun, 23 Aug, 05:44 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4877

  7. Christian Kuhn updated the commit message in patch set 4 08/23/20, 17:44

  8. TYPO3com voted on patch set 4 V -1 08/23/20, 17:44 Completed build in 28s on Sun, 23 Aug, 05:44 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4878

  9. Christian Kuhn uploaded patch set 5 08/23/20, 17:49

  10. TYPO3com voted on patch set 5 V +1 08/23/20, 18:00 Completed build in 11m 03s on Sun, 23 Aug, 06:00 PM Test Summary: 73065 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4879

  11. Anja Leichsenring updated the commit message in patch set 6 08/23/20, 18:11

  12. Anja Leichsenring voted on patch set 6 V +1 CR +1 08/23/20, 18:18

  13. TYPO3com voted on patch set 6 V +1 08/23/20, 18:23 Completed build in 11m 21s on Sun, 23 Aug, 06:23 PM Test Summary: 73065 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4880

  14. Andreas Kienast commented on patch set 6 CR +1 08/24/20, 18:15

    BackendConfigurationManager.php:258 Unresolved

    nice one
  15. Andreas Kienast commented on patch set 6 08/24/20, 18:55

    WorkspaceService.php:551

    Would it make sense to have an `array_unique()` here? Think of nested web mounts, been there, done that.
  16. Andreas Kienast voted on patch set 6 V +1 08/24/20, 19:06

  17. Christian Kuhn commented on patch set 6 08/24/20, 19:30

    WorkspaceService.php:551 Reply Unresolved

    good point.
  18. Christian Kuhn uploaded patch set 7 08/24/20, 19:32

  19. TYPO3com voted on patch set 7 V +1 08/24/20, 19:43 Completed build in 10m 31s on Mon, 24 Aug, 07:43 PM Test Summary: 73064 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4922

  20. Andreas Kienast voted on patch set 7 V +1 CR +1 08/25/20, 06:41

  21. Anja Leichsenring voted on patch set 7 V +2 CR +2 08/25/20, 17:10

  22. Anja Leichsenring merged patch set 8 08/25/20, 17:10