Review main Merged

65444[BUGFIX] Raise minimum version of typo3/testing-framework to 6.4.1

Anja Leichsenring CR +2 V +2 Easy +4 −3 updated 08/24/20, 07:28

Commit message

The changes in #91990 required at least version 6.4.1, but the version was
not pinned in composer.json to reflect that (only composer.lock was
updated). Therefore bamboo nightly composer min stage failed.

Used command:
	composer require --dev typo3/testing-framework:^6.4.1

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Richard Haeser +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • TYPO3com +1 CI

Issues 2

Files 3

Review log 1017

  1. Anja Leichsenring uploaded patch set 1 08/24/20, 05:56

  2. Anja Leichsenring voted on patch set 1 V -1 08/24/20, 05:57

  3. Anja Leichsenring uploaded patch set 2 08/24/20, 06:06

  4. TYPO3com voted on patch set 1 V -1 08/24/20, 06:07 Completed build in 11m 08s on Mon, 24 Aug, 06:07 AM Test Summary: 73074 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4886

  5. Anja Leichsenring uploaded patch set 3 08/24/20, 06:09

  6. Benjamin Franzke updated the commit message in patch set 4 08/24/20, 06:12

  7. Anja Leichsenring updated the commit message in patch set 5 08/24/20, 06:15

  8. Benjamin Franzke voted on patch set 5 V +1 CR +1 08/24/20, 06:16

  9. Richard Haeser voted on patch set 5 CR +1 08/24/20, 06:23

  10. TYPO3com voted on patch set 2 V -1 08/24/20, 06:36 Completed build in 29m 42s on Mon, 24 Aug, 06:36 AM Test Summary: 9 of 73561 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4887

  11. TYPO3com voted on patch set 3 V -1 08/24/20, 06:42 Completed build in 27m 03s on Mon, 24 Aug, 06:42 AM Test Summary: 3 of 73560 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4889

  12. TYPO3com voted on patch set 4 V -1 08/24/20, 06:44 Completed build in 28m 20s on Mon, 24 Aug, 06:44 AM Test Summary: 10 of 73548 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4890

  13. TYPO3com voted on patch set 5 V -1 08/24/20, 06:45 Completed build in 29m 43s on Mon, 24 Aug, 06:45 AM Test Summary: 72762 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4891

  14. TYPO3com voted on patch set 5 V +1 08/24/20, 07:20 Completed build in 10m 59s on Mon, 24 Aug, 07:20 AM Test Summary: 73074 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4893

  15. TYPO3com commented on patch set 5 08/24/20, 07:21 Completed build in 1h 35m 09s on Mon, 24 Aug, 07:21 AM Test Summary: 73074 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4891

  16. Andreas Kienast voted on patch set 5 V +2 CR +2 08/24/20, 07:28

  17. Andreas Kienast merged patch set 6 08/24/20, 07:28