Review main Merged

65446[TASK] DatabaseRecordList: Drop internal property oddColumnsCssClass

Daniel Windloff CR +2 V +2 Easy +0 −13 updated 08/25/20, 17:25

Commit message

The internal property oddColumnsCssClass is always empty.
So it has been removed.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 78

  1. Daniel Windloff uploaded patch set 1 08/24/20, 07:03

  2. TYPO3com voted on patch set 1 V +1 08/24/20, 07:15 Completed build in 11m 50s on Mon, 24 Aug, 07:15 AM Test Summary: 73074 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4892

  3. Jörg Bösche commented on patch set 1 08/25/20, 11:13

    We should add a RST file to describe the removal of public property $addColumnsCssClass in DatabaseRecordList class. There could be third-party extensions that use the public attribute.
  4. Daniel Windloff commented on patch set 1 08/25/20, 14:23

    > Patch Set 1: > > We should add a RST file to describe the removal of public property $addColumnsCssClass in DatabaseRecordList class. There could be third-party extensions that use the public attribute. What kind of rst file do you suggest? The whole class is marked as internal and the property itself is also in the internal section so it's not a breaking change as the property is not part of the core API. Perhaps the best way would be to collect those changes in an important rst file as a kind of notice for a breaking in internal class. I don't know if something else fits better..
  5. Jörg Bösche commented on patch set 1 08/25/20, 14:57

    > Patch Set 1: > > > Patch Set 1: > > > > We should add a RST file to describe the removal of public property $addColumnsCssClass in DatabaseRecordList class. There could be third-party extensions that use the public attribute. > > What kind of rst file do you suggest? > The whole class is marked as internal and the property itself is also in the internal section so it's not a breaking change as the property is not part of the core API. > > Perhaps the best way would be to collect those changes in an important rst file as a kind of notice for a breaking in internal class. I don't know if something else fits better.. I had the following in idea. A rst file with a short info about removed or deprecated properties. E.g.: https://docs.typo3.org/c/typo3/cms-core/master/en-us/Changelog/9.4/Deprecation-85389-VariousPublicPropertiesInFavorOfContextAPI.html
  6. Christian Kuhn commented on patch set 1 V +1 CR +1 08/25/20, 17:24

    I think a general .rst file for the class that is currently under heavy refactoring could be useful in the end. Let us add that later when the heavy lifting is done, though: Daniel is correct that the class is @internal, so strictly speaking we'd not need a .rst file at all ...
  7. Anja Leichsenring voted on patch set 1 V +2 CR +2 08/25/20, 17:25

  8. Anja Leichsenring merged patch set 2 08/25/20, 17:25