Review main Merged

65447[BUGFIX] Discarding record in workspaces deletes move placeholder

Christian Kuhn CR +2 V +2 Hard +374 −30 updated 08/25/20, 17:06

Commit message

When discarding a workspace change of a record that has been
moved, the move-to-pointer (t3ver_state=3) is not set to
deleted=1 as it should. This leads to issues, for instance
the list module shows the records twice.
The patch partially fixes this behavior: For top-level
records, move pointer are now properly deleted as shown
by Regular/Modify test moveContentToDifferentPageAndDiscard
for a 'discard' case, and for a 'flush' related test case
in existing deletingSysWorkspaceDeletesWorkspaceRecordsResult,
which removes two todos.
For relations, the issue is harder to tackle, for now
coverage is added for inline csv and foreignField, to nail
with @todos that delete cascading of move pointer records is
still troublesome.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Achim Fritz +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Achim Fritz +1
    • TYPO3com +1 CI

Issues 1

Files 15

Review log 1322

  1. Christian Kuhn uploaded patch set 1 08/24/20, 11:33

  2. TYPO3com voted on patch set 1 V +1 08/24/20, 11:45 Completed build in 11m 46s on Mon, 24 Aug, 11:45 AM Test Summary: 73074 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4898

  3. Christian Kuhn uploaded patch set 2 08/24/20, 12:39

  4. TYPO3com voted on patch set 2 V +1 08/24/20, 12:51 Completed build in 11m 41s on Mon, 24 Aug, 12:51 PM Test Summary: 73074 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4899

  5. Christian Kuhn uploaded patch set 3 08/24/20, 15:02

  6. TYPO3com voted on patch set 3 V -1 08/24/20, 15:03 Completed build in 00s on Mon, 24 Aug, 03:03 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4906

  7. Christian Kuhn uploaded patch set 4 08/24/20, 15:07

  8. TYPO3com voted on patch set 4 V +1 08/24/20, 15:20 Completed build in 12m 31s on Mon, 24 Aug, 03:20 PM Test Summary: 73080 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4907

  9. Christian Kuhn uploaded patch set 5 08/24/20, 16:10

  10. TYPO3com voted on patch set 5 V -1 08/24/20, 16:21 Completed build in 10m 58s on Mon, 24 Aug, 04:21 PM Test Summary: 339 of 73571 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4910

  11. Christian Kuhn uploaded patch set 6 08/24/20, 16:53

  12. TYPO3com voted on patch set 6 V -1 08/24/20, 16:54 Completed build in 24s on Mon, 24 Aug, 04:54 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4912

  13. Christian Kuhn uploaded patch set 7 08/24/20, 16:55

  14. TYPO3com voted on patch set 7 V +1 08/24/20, 17:06 Completed build in 11m 28s on Mon, 24 Aug, 05:06 PM Test Summary: 73085 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4913

  15. Christian Kuhn uploaded patch set 8 08/24/20, 17:29

  16. TYPO3com voted on patch set 8 V +1 08/24/20, 17:41 Completed build in 11m 42s on Mon, 24 Aug, 05:41 PM Test Summary: 73092 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4916

  17. Christian Kuhn updated the commit message in patch set 9 08/24/20, 18:03

  18. TYPO3com voted on patch set 9 V +1 08/24/20, 18:14 Completed build in 11m 37s on Mon, 24 Aug, 06:14 PM Test Summary: 73092 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4919

  19. Achim Fritz voted on patch set 9 V +1 CR +1 08/25/20, 12:40

  20. Oliver Hader voted on patch set 9 CR +1 08/25/20, 13:58

  21. Anja Leichsenring voted on patch set 9 V +2 CR +2 08/25/20, 17:06

  22. Anja Leichsenring merged patch set 10 08/25/20, 17:06