Review main Abandoned

65448[BUGFIX] Bamboo: Failsafe shutdown of Docker containers and networks

Andreas Kienast CR 0 V 0 Easy +6 −5 updated 09/04/20, 13:43

Commit message

Checking whether a container is still running before shutdown to avoid
false errors seems to be unstable which doesn't shut down the related
networks under some circumstances.

For this reason, we now always try to shut down the containers and catch
possible "errors" ("no such container"). Additionally, we disconnect the
networks as well.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 46

  1. Andreas Kienast uploaded patch set 1 08/24/20, 14:51

  2. Andreas Kienast updated the commit message in patch set 2 08/24/20, 14:59

  3. TYPO3com voted on patch set 1 V +1 08/24/20, 15:03 Completed build in 12m 35s on Mon, 24 Aug, 03:03 PM Test Summary: 73074 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4903

  4. Andreas Kienast commented on patch set 2 CR -2 08/24/20, 15:19

    I'll wait until tomorrow before merging until the nightlies are done
  5. TYPO3com voted on patch set 2 V -1 08/24/20, 15:32 Completed build in 32m 51s on Mon, 24 Aug, 03:32 PM Test Summary: 64 of 73511 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4904

  6. Andreas Kienast abandoned the change 09/04/20, 13:43