65449[FEATURE] Support autowired LoggerInterface injection
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Nikita Hovratov +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Nikita Hovratov +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 4
Review log 1522
-
Benjamin Franzke uploaded patch set 1 08/25/20, 08:25
-
TYPO3com voted on patch set 1 V -1 08/25/20, 08:37 Completed build in 11m 59s on Tue, 25 Aug, 08:37 AM Test Summary: 73072 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4936
-
Benjamin Franzke uploaded patch set 2 08/25/20, 10:23
-
TYPO3com voted on patch set 2 V -1 08/25/20, 10:46 Completed build in 19m 51s on Tue, 25 Aug, 10:46 AM Test Summary: 2 of 73561 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4943
-
TYPO3com voted on patch set 2 V +1 08/25/20, 11:32 Completed build in 11m 47s on Tue, 25 Aug, 11:32 AM Test Summary: 73074 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4946
-
Benni Mack commented on patch set 2 06/14/21, 11:31
Should we push this forward as Feature v11? -
Benjamin Franzke uploaded patch set 3 08/31/21, 07:30
-
Benjamin Franzke commented on patch set 3 08/31/21, 07:30
Reply
Yea, I mean, while Larry is working on monolog https://review.typo3.org/c/Packages/TYPO3.CMS/+/70014 …that monolog integration seems not really to be "finished" to me, so it would be useful to have this as feature for v11 anyway. -
core-ci voted on patch set 3 V -1 08/31/21, 07:50 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15908
-
Benjamin Franzke uploaded patch set 4 08/31/21, 08:10
-
core-ci voted on patch set 4 V +1 08/31/21, 08:27 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15911
-
Benni Mack commented on patch set 4 09/02/21, 10:06
Scheduler.php:37you can use PHP 7.4 typed properties here.Scheduler.php:484looks weird. this would mean "[scheduler]:" is added twice. -
Benjamin Franzke uploaded patch set 5 09/02/21, 11:48
-
Benjamin Franzke commented on patch set 5 09/02/21, 11:48
Scheduler.php:37ReplyAckScheduler.php:484Replyoops, mistake during rebase. Fixed. -
core-ci voted on patch set 5 V +1 09/02/21, 12:05 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16070
-
Nikita Hovratov voted on patch set 5 V +1 CR +1 09/02/21, 14:53
-
Benjamin Franzke uploaded patch set 6 09/02/21, 21:27
-
core-ci voted on patch set 6 V +1 09/02/21, 21:44 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16138
-
Benni Mack voted on patch set 6 V +1 CR +1 09/03/21, 06:58
-
Nikita Hovratov voted on patch set 6 V +1 CR +1 09/03/21, 07:49
-
Benjamin Franzke voted on patch set 6 V +2 CR +2 09/03/21, 08:51
-
Benjamin Franzke merged patch set 7 09/03/21, 08:51