Review main Merged

65451[BUGFIX] Properly set user to admin in setup module

Christian Kuhn CR +2 V +2 Easy +8 −3 updated 08/26/20, 12:48

Commit message

SetupModuleController serves as a backdoor so regular users without
permission to manipulate be_users records can still edit their profile.
For this to work, the access check needs to be bypassed for this
particular record by DataHandler.

The start() method of DataHandler prepares e.g. exclude fields to be checked.
With current code, incoming user is not yet set to admin, so exclude field
checking may fail, especially if 3rd party extensions manipulate this.
The patch hands a temporary user with activated admin flag to DataHandler,
so it can bypass the access check for profile editing.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 610

  1. Christian Kuhn uploaded patch set 1 08/25/20, 13:05

  2. TYPO3com voted on patch set 1 V +1 08/25/20, 13:16 Completed build in 11m 09s on Tue, 25 Aug, 01:16 PM Test Summary: 73074 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4949

  3. Anja Leichsenring updated the commit message in patch set 2 08/26/20, 05:14

  4. Anja Leichsenring commented on patch set 3 08/26/20, 05:16

    Published edit on patch set 2.
  5. TYPO3com voted on patch set 3 V -1 08/26/20, 05:39 Completed build in 21m 09s on Wed, 26 Aug, 05:39 AM Test Summary: 71808 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4968

  6. TYPO3com voted on patch set 3 V +1 08/26/20, 05:53 Completed build in 56m 24s on Wed, 26 Aug, 05:53 AM Test Summary: 73092 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4968

  7. TYPO3com voted on patch set 2 V -1 08/26/20, 06:16 Completed build in 1h 02m 30s on Wed, 26 Aug, 06:16 AM Test Summary: 479 of 71554 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4967

  8. Anja Leichsenring voted on patch set 3 V +1 CR +1 08/26/20, 07:39

  9. Andreas Kienast voted on patch set 3 V +2 CR +2 08/26/20, 12:48

  10. Andreas Kienast merged patch set 4 08/26/20, 12:48