Review main Merged

65453[BUGFIX] Workspace relations in ElementInformationController

Christian Kuhn CR +2 V +2 Easy +5 −8 updated 08/26/20, 12:59

Commit message

When relations are added in a workspace, the 'info' modal
of the parent record does not reflect those. The patch changes
the reference resolving to work with the overlay record uid if
given. This fixes reference record display for inline records
including file references.
There are further issues with the rendered record, those
however are resolved by other core methods and can be
fixed with other patches.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Achim Fritz +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Achim Fritz +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 68

  1. Christian Kuhn uploaded patch set 1 08/25/20, 16:30

  2. Christian Kuhn voted on patch set 1 CR -1 08/25/20, 16:30

  3. TYPO3com voted on patch set 1 V +1 08/25/20, 16:41 Completed build in 10m 52s on Tue, 25 Aug, 04:41 PM Test Summary: 73074 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4958

  4. Christian Kuhn uploaded patch set 2 08/26/20, 12:14

  5. TYPO3com voted on patch set 2 V +1 08/26/20, 12:25 Completed build in 11m 03s on Wed, 26 Aug, 12:25 PM Test Summary: 73092 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4978

  6. Achim Fritz voted on patch set 2 V +1 CR +1 08/26/20, 12:49

  7. Andreas Kienast voted on patch set 2 V +2 CR +2 08/26/20, 12:59

  8. Andreas Kienast merged patch set 3 08/26/20, 12:59