Review 10.4 Merged

65455[BUGFIX] IRRE: Handle localizable records correctly

Anja Leichsenring CR +2 V +2 Easy +4 −3 updated 08/25/20, 19:32

Commit message

Each node in an IRRE container now has a new `data-placeholder-record`
attribute to be able to identify such node w/out accessing CSS classes
used for styling purpose.

Nodes where `data-placeholder-record` has a truthy value are localizable
and are ignored now when the sorting is changed which solves an issue
where such records would have been moved into a different language.

In the same run the localization is fixed as it was tried to iterate an
object, which doesn't work. Alternatively, the object values are fetched
and iterated now.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
  • Verified V +2 Done
    • Anja Leichsenring +2
    • TYPO3com +1 CI

Issues 2

Files 3

Review log 46

  1. Anja Leichsenring uploaded patch set 1 08/25/20, 19:15

  2. TYPO3com voted on patch set 1 V -1 08/25/20, 19:16 Completed build in 20s on Tue, 25 Aug, 07:16 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-274

  3. Anja Leichsenring uploaded patch set 2 08/25/20, 19:17

  4. TYPO3com voted on patch set 2 V +1 08/25/20, 19:29 Completed build in 11m 26s on Tue, 25 Aug, 07:29 PM Test Summary: 74043 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-275

  5. Anja Leichsenring voted on patch set 2 V +2 CR +2 08/25/20, 19:32

  6. Anja Leichsenring merged patch set 3 08/25/20, 19:32