Review main Merged

65457[TASK] Merge QueryView with QueryGenerator and move to lowlevel

Christian Kuhn CR +2 V +2 Nightmare +2807 −68 updated 08/31/20, 18:20

Commit message

The classes QueryView and QueryGenerator in the core extension
are detail implementations of the databases search functionality
of the lowlevel extension.
The patch merges both classes into one, moves it to the lowlevel
extension and deprecates the old classes. Minor refactorings like
protecting properties and methods is applied to the new class to
enable further refactoring if desired.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 2

Files 8

Review log 911

  1. Christian Kuhn uploaded patch set 1 08/25/20, 21:11

  2. Christian Kuhn commented on patch set 1 CR -1 08/25/20, 21:11

    will finish soon
  3. TYPO3com voted on patch set 1 V -1 08/25/20, 21:34 Completed build in 22m 51s on Tue, 25 Aug, 09:34 PM Test Summary: 522 of 73184 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4965

  4. Christian Kuhn uploaded patch set 2 08/29/20, 11:29

  5. TYPO3com voted on patch set 2 V +1 08/29/20, 11:39 Completed build in 10m 44s on Sat, 29 Aug, 11:39 AM Test Summary: 73092 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5042

  6. Christian Kuhn voted on patch set 2 V +1 CR +1 08/30/20, 15:12

  7. Benni Mack commented on patch set 2 08/31/20, 12:19

    should we add ClassAliases for it?
  8. Christian Kuhn commented on patch set 2 08/31/20, 15:30

    class aliases don't make sense here, imho.
  9. Anja Leichsenring voted on patch set 2 V +1 CR +1 08/31/20, 16:38

  10. Benni Mack voted on patch set 2 V +2 CR +2 08/31/20, 18:19

  11. Benni Mack merged patch set 3 08/31/20, 18:20