Review main Merged

65458[BUGFIX] Import data from yaml imports in declaration order

Jigal van Hemert CR +2 V +2 Normal +109 −1 updated 02/23/21, 12:59

Commit message

For plain arrays it's sometimes important that the items
appear in the order in which they are imported. For example
with the languages in the sites configuration where the first
language is seen as the default language.

Just like with Symfony Service Container imports come first
and its settings are overwritten with the main file. To make
sure that multiple imports are loaded in the order as they
appear in the main file they must be processed in reverse
order.

This behaviour can now be controlled by a new feature toggle
which defaults to `false` for existing and to `true` for new
installations.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Oli Bartsch +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 6

Review log 2841

Show 1216 earlier messages
  1. Jigal van Hemert uploaded patch set 1 08/26/20, 05:08

  2. TYPO3com voted on patch set 1 V -1 08/26/20, 05:31 Completed build in 22m 55s on Wed, 26 Aug, 05:31 AM Test Summary: 32 of 73577 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4966

  3. TYPO3com commented on patch set 1 08/26/20, 06:14 Completed build in 28m 59s on Wed, 26 Aug, 06:14 AM Test Summary: 18 of 73577 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4970

  4. Jigal van Hemert uploaded patch set 2 08/27/20, 12:37

  5. TYPO3com voted on patch set 2 V +1 08/27/20, 12:49 Completed build in 11m 31s on Thu, 27 Aug, 12:49 PM Test Summary: 73098 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5011

  6. Richard Haeser updated the commit message in patch set 3 08/28/20, 07:24

  7. TYPO3com voted on patch set 3 V +1 08/28/20, 07:36 Completed build in 11m 19s on Fri, 28 Aug, 07:36 AM Test Summary: 73098 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5022

  8. Richard Haeser commented on patch set 3 V +1 CR +1 09/07/20, 18:33

    As discussed in person, not sure if this is a breaking change or not. If people have included files in the reversed order, the imports can give a different result.
  9. Daniel Siepmann voted on patch set 3 CR +1 10/07/20, 13:11

  10. Daniel Siepmann wrote 10/07/20, 13:21

    Removed Code-Review+1 by Daniel Siepmann <coding@daniel-siepmann.de>
  11. Richard Haeser commented on patch set 3 V 0 10/07/20, 13:25

    The backporting part is still bothering me. Can be breaking!
  12. Markus Klein commented on patch set 3 CR -1 10/07/20, 13:28

    I agree to the change itself, but this can be heavily breaking for existing setups. This is a [!!!] change can can be master only. Other option: use a feature-switch to enable this different behaviour
  13. Claus Due commented on patch set 3 CR +1 10/07/20, 13:38

    I'll be the dissenting voice here, my argument is that any setup that will break because of this change, is actually programmed to assume an incorrect/illogical behavior. Therefore I am fine with both the change and the backport request. It does however merit an "Important" RST just to communicate the changed behavior; along with an example of a setup that may be assuming an incorrect behavior and therefore needs to be corrected after this patch.
  14. Simon Gilli voted on patch set 3 CR +1 10/08/20, 07:56

  15. Georg Ringer commented on patch set 3 10/08/20, 11:05

    I agree with markus: please provide a rst + feature toggle for that for 10 and no 9.5 change needed for that
  16. Josef Glatz commented on patch set 3 10/08/20, 17:16

    > Patch Set 3: > > I agree with markus: please provide a rst + feature toggle for that for 10 and no 9.5 change needed for that That sounds great. i just became a victim of this issue. Having that in 10.4 with a feature-toggle and important rst for master would be really cool. For 11 I would suggest to fix it by default.
  1. Benni Mack commented on patch set 3 01/15/21, 13:33

    I do think this patch is very good, but it really has a lot of impact (just as mentioned, people use the workaround actively in their current setups). For this reason: I suggest building a feature toggle via the Features API (with an important RST) "logicalOrderingInYamlImports", going all the way back into v9, having the feature toggle deactivated for existing installations (DefaultConfiguration.php) but activated for new installations (FactoryConfiguration.php), and then removing the feature toggle in v12.
  2. Oli Bartsch uploaded patch set 4 01/21/21, 10:48

  3. Oli Bartsch updated the commit message in patch set 5 01/21/21, 10:48

  4. Oli Bartsch voted on patch set 5 V +1 CR +1 01/21/21, 10:54

  5. TYPO3com voted on patch set 4 V +1 01/21/21, 10:58 Completed build in 10m 13s on Thu, 21 Jan, 10:58 AM Test Summary: 32603 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8954

  6. TYPO3com voted on patch set 5 V -1 01/21/21, 11:10 Completed build in 21m 23s on Thu, 21 Jan, 11:10 AM Test Summary: 20898 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8956

  7. TYPO3com commented on patch set 5 01/21/21, 11:49 Completed build in 1h 21m 53s on Thu, 21 Jan, 11:49 AM Test Summary: 1 of 32844 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8956

  8. TYPO3com voted on patch set 5 V +1 01/21/21, 11:59 Completed build in 2h 32m 08s on Thu, 21 Jan, 11:59 AM Test Summary: 32603 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8956

  9. Richard Haeser updated the commit message in patch set 6 02/23/21, 10:30

  10. Richard Haeser voted on patch set 6 V +1 CR +1 02/23/21, 10:30

  11. Richard Haeser commented on patch set 6 V 0 CR -1 02/23/21, 10:35

    The Important RST need to be moved to another folder. On it
  12. TYPO3com voted on patch set 6 V +1 02/23/21, 10:37 Completed build in 07m 08s on Tue, 23 Feb, 10:37 AM Test Summary: 32686 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9675

  13. Markus Klein commented on patch set 6 CR -1 02/23/21, 10:45

    DefaultConfiguration.php:78

    Disagree on this naming. "What is logical? To whom?"
  14. Richard Haeser commented on patch set 6 02/23/21, 10:49

    DefaultConfiguration.php:78 Reply

    Well as far almost all coding languages work from top to bottom. So you expect (is logical) that the first entry in your imports is handled first and the last one at last. So that is why I think logical is perfectly fine. What would you suggest?
  15. Richard Haeser uploaded patch set 7 02/23/21, 10:50

  16. Richard Haeser voted on patch set 7 V +1 CR +1 02/23/21, 10:51

  17. Markus Klein commented on patch set 7 CR -1 02/23/21, 10:57

    DefaultConfiguration.php:78 Reply

    "importsInYamlFollowDeclarationOrder" "yamlImportsAdhereOrderAsDefined"
  18. TYPO3com voted on patch set 7 V +1 02/23/21, 11:01 Completed build in 11m 05s on Tue, 23 Feb, 11:01 AM Test Summary: 32686 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9677

  19. core-ci voted on patch set 7 V +1 02/23/21, 11:05 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/911

  20. Oli Bartsch uploaded patch set 8 02/23/21, 12:29

  21. Oli Bartsch commented on patch set 8 V +1 CR +1 02/23/21, 12:31

    DefaultConfiguration.php:78 Reply

    Done
  22. TYPO3com voted on patch set 8 V +1 02/23/21, 12:36 Completed build in 06m 47s on Tue, 23 Feb, 12:36 PM Test Summary: 32686 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9678

  23. core-ci voted on patch set 8 V +1 02/23/21, 12:39 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/912

  24. Richard Haeser voted on patch set 8 V +2 CR +2 02/23/21, 12:58

  25. Richard Haeser merged patch set 9 02/23/21, 12:59