Review main Merged

65462[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:workspaces

Alexander Schnitzler CR +2 V +2 Normal +34 −28 updated 09/05/20, 12:48

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 13

Review log 1519

  1. Alexander Schnitzler uploaded patch set 1 08/26/20, 13:03

  2. Alexander Schnitzler wrote 08/26/20, 13:04

    Topic set to phpstan
  3. TYPO3com voted on patch set 1 V -1 08/26/20, 13:48 Completed build in 44m 55s on Wed, 26 Aug, 01:48 PM Test Summary: 71793 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4981

  4. Jörg Bösche commented on patch set 1 CR -1 08/27/20, 12:12

    EventCallback.php:63 Unresolved

    Should extracted as variable outside of the condition. Increases readability. $callable = [$this->object, $this->method]); if (is_callable($callable) ....

    GridDataService.php:458

    We should add strict parameter here.
  5. Alexander Schnitzler commented on patch set 1 08/27/20, 14:39

    GridDataService.php:458 Reply Unresolved

    The idea is to do that later with rector. That's why these patches exist that guarantee future type compatibility based on the @param annotations.
  6. Alexander Schnitzler uploaded patch set 2 08/28/20, 07:43

  7. TYPO3com voted on patch set 2 V +1 08/28/20, 07:55 Completed build in 11m 18s on Fri, 28 Aug, 07:55 AM Test Summary: 73092 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5023

  8. Jörg Bösche voted on patch set 2 CR +1 08/28/20, 07:56

  9. Oliver Klee voted on patch set 2 CR +1 08/28/20, 10:34

  10. Andreas Kienast commented on patch set 2 08/28/20, 15:22

    GridDataService.php:153 Unresolved

    Theoretically, this may have an impact on caching, as the $versions array is passed to getDataArrayFromCache() before to check whether further processing is necessary and to setDataArrayIntoCache() afterward. Practically, this would be broken before if $table wouldn't be a string (= invalid table name) already. Proceed however you like here.
  11. Alexander Schnitzler uploaded patch set 3 09/02/20, 10:11

  12. TYPO3com voted on patch set 3 V +1 09/02/20, 10:24 Completed build in 12m 37s on Wed, 2 Sep, 10:24 AM Test Summary: 73164 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5128

  13. Jörg Bösche voted on patch set 3 CR +1 09/03/20, 10:07

  14. Alexander Schnitzler updated the commit message in patch set 4 09/03/20, 15:43

  15. TYPO3com voted on patch set 4 V +1 09/03/20, 16:00 Completed build in 15m 46s on Thu, 3 Sep, 04:00 PM Test Summary: 73182 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5187

  16. Oliver Klee voted on patch set 4 CR +1 09/04/20, 07:51

  17. Benni Mack voted on patch set 4 V +1 CR +1 09/05/20, 12:28

  18. Christian Kuhn voted on patch set 4 V +2 CR +2 09/05/20, 12:48

  19. Christian Kuhn merged patch set 5 09/05/20, 12:48