65462[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:workspaces
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 13
- typo3/sysext/workspaces/Classes/Command/WorkspaceVersionRecordsCommand.php+1 −1
- typo3/sysext/workspaces/Classes/Controller/Remote/ActionHandler.php+1 −1
- typo3/sysext/workspaces/Classes/Controller/Remote/RemoteServer.php+6 −6
- typo3/sysext/workspaces/Classes/Controller/AjaxDispatcher.php+1 −1
- typo3/sysext/workspaces/Classes/DataHandler/CommandMap.php+6 −5
- typo3/sysext/workspaces/Classes/Dependency/EventCallback.php1+5 −1
- typo3/sysext/workspaces/Classes/Hook/DataHandlerHook.php+2 −2
- typo3/sysext/workspaces/Classes/Middleware/WorkspacePreview.php+2 −2
- typo3/sysext/workspaces/Classes/Notification/StageChangeNotification.php+1 −1
- typo3/sysext/workspaces/Classes/Preview/PreviewUriBuilder.php+1 −1
- typo3/sysext/workspaces/Classes/Service/GridDataService.php3+6 −5
- typo3/sysext/workspaces/Classes/Service/StagesService.php+1 −1
- typo3/sysext/workspaces/Classes/Service/WorkspaceService.php+1 −1
Review log 1519
-
Alexander Schnitzler uploaded patch set 1 08/26/20, 13:03
-
Alexander Schnitzler wrote 08/26/20, 13:04
Topic set to phpstan -
TYPO3com voted on patch set 1 V -1 08/26/20, 13:48 Completed build in 44m 55s on Wed, 26 Aug, 01:48 PM Test Summary: 71793 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4981
-
Jörg Bösche commented on patch set 1 CR -1 08/27/20, 12:12
EventCallback.php:63UnresolvedShould extracted as variable outside of the condition. Increases readability. $callable = [$this->object, $this->method]); if (is_callable($callable) ....GridDataService.php:458We should add strict parameter here. -
Alexander Schnitzler commented on patch set 1 08/27/20, 14:39
GridDataService.php:458Reply UnresolvedThe idea is to do that later with rector. That's why these patches exist that guarantee future type compatibility based on the @param annotations. -
Alexander Schnitzler uploaded patch set 2 08/28/20, 07:43
-
TYPO3com voted on patch set 2 V +1 08/28/20, 07:55 Completed build in 11m 18s on Fri, 28 Aug, 07:55 AM Test Summary: 73092 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5023
-
Jörg Bösche voted on patch set 2 CR +1 08/28/20, 07:56
-
Oliver Klee voted on patch set 2 CR +1 08/28/20, 10:34
-
Andreas Kienast commented on patch set 2 08/28/20, 15:22
GridDataService.php:153UnresolvedTheoretically, this may have an impact on caching, as the $versions array is passed to getDataArrayFromCache() before to check whether further processing is necessary and to setDataArrayIntoCache() afterward. Practically, this would be broken before if $table wouldn't be a string (= invalid table name) already. Proceed however you like here. -
Alexander Schnitzler uploaded patch set 3 09/02/20, 10:11
-
TYPO3com voted on patch set 3 V +1 09/02/20, 10:24 Completed build in 12m 37s on Wed, 2 Sep, 10:24 AM Test Summary: 73164 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5128
-
Jörg Bösche voted on patch set 3 CR +1 09/03/20, 10:07
-
Alexander Schnitzler updated the commit message in patch set 4 09/03/20, 15:43
-
TYPO3com voted on patch set 4 V +1 09/03/20, 16:00 Completed build in 15m 46s on Thu, 3 Sep, 04:00 PM Test Summary: 73182 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5187
-
Oliver Klee voted on patch set 4 CR +1 09/04/20, 07:51
-
Benni Mack voted on patch set 4 V +1 CR +1 09/05/20, 12:28
-
Christian Kuhn voted on patch set 4 V +2 CR +2 09/05/20, 12:48
-
Christian Kuhn merged patch set 5 09/05/20, 12:48