65465[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:core
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 116
- typo3/sysext/core/Classes/Authentication/AbstractUserAuthentication.php+2 −2
- typo3/sysext/core/Classes/Authentication/AuthenticationService.php+1 −1
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php2+4 −4
- typo3/sysext/core/Classes/Authentication/IpLocker.php+3 −2
- typo3/sysext/core/Classes/Cache/Backend/AbstractBackend.php+2 −0
- typo3/sysext/core/Classes/Cache/Backend/FileBackend.php2+10 −10
- typo3/sysext/core/Classes/Cache/Backend/PdoBackend.php2+1 −1
- typo3/sysext/core/Classes/Cache/Backend/RedisBackend.php+1 −1
- typo3/sysext/core/Classes/Cache/Backend/SimpleFileBackend.php+1 −1
- typo3/sysext/core/Classes/Cache/Backend/Typo3DatabaseBackend.php+2 −2
- typo3/sysext/core/Classes/Cache/CacheManager.php+1 −1
- typo3/sysext/core/Classes/Charset/CharsetConverter.php+9 −9
- typo3/sysext/core/Classes/Composer/CliEntryPoint.php+1 −1
- typo3/sysext/core/Classes/Configuration/FlexForm/FlexFormTools.php+2 −2
- typo3/sysext/core/Classes/Configuration/Loader/PageTsConfigLoader.php+1 −1
- typo3/sysext/core/Classes/Configuration/ExtensionConfiguration.php+1 −1
- typo3/sysext/core/Classes/Core/ClassLoadingInformationGenerator.php+6 −6
- typo3/sysext/core/Classes/Core/SystemEnvironmentBuilder.php+4 −4
- typo3/sysext/core/Classes/Crypto/PasswordHashing/BlowfishPasswordHash.php+1 −1
- typo3/sysext/core/Classes/Crypto/PasswordHashing/Pbkdf2PasswordHash.php+2 −2
Show 96 more files
- typo3/sysext/core/Classes/Crypto/PasswordHashing/PhpassPasswordHash.php+1 −1
- typo3/sysext/core/Classes/Database/Query/Expression/ExpressionBuilder.php1+2 −2
- typo3/sysext/core/Classes/Database/Query/QueryHelper.php+3 −3
- typo3/sysext/core/Classes/Database/Schema/EventListener/SchemaColumnDefinitionListener.php+3 −3
- typo3/sysext/core/Classes/Database/Schema/EventListener/SchemaIndexDefinitionListener.php+1 −1
- typo3/sysext/core/Classes/Database/Schema/Parser/Parser.php+5 −5
- typo3/sysext/core/Classes/Database/Schema/ConnectionMigrator.php+2 −1
- typo3/sysext/core/Classes/Database/Schema/SqlReader.php+2 −2
- typo3/sysext/core/Classes/Database/QueryGenerator.php+17 −17
- typo3/sysext/core/Classes/Database/QueryView.php+6 −6
- typo3/sysext/core/Classes/Database/ReferenceIndex.php+3 −3
- typo3/sysext/core/Classes/Database/RelationHandler.php+11 −11
- typo3/sysext/core/Classes/Database/SoftReferenceIndex.php+2 −1
- typo3/sysext/core/Classes/DataHandling/Localization/DataMapItem.php+2 −1
- typo3/sysext/core/Classes/DataHandling/Localization/DataMapProcessor.php+11 −11
- typo3/sysext/core/Classes/DataHandling/Localization/State.php+1 −1
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+62 −60
- typo3/sysext/core/Classes/DataHandling/SlugHelper.php+4 −4
- typo3/sysext/core/Classes/DependencyInjection/ContainerBuilder.php+1 −1
- typo3/sysext/core/Classes/DependencyInjection/ServiceProviderRegistry.php+3 −2
- typo3/sysext/core/Classes/Domain/Repository/PageRepository.php+2 −2
- typo3/sysext/core/Classes/ExpressionLanguage/ProviderInterface.php+2 −2
- typo3/sysext/core/Classes/Html/HtmlParser.php+5 −5
- typo3/sysext/core/Classes/Html/RteHtmlParser.php+3 −3
- typo3/sysext/core/Classes/Http/NormalizedParams.php+2 −2
- typo3/sysext/core/Classes/Http/Response.php+1 −1
- typo3/sysext/core/Classes/Http/ServerRequestFactory.php+1 −1
- typo3/sysext/core/Classes/Http/UploadedFile.php+1 −1
- typo3/sysext/core/Classes/Http/Uri.php+1 −1
- typo3/sysext/core/Classes/Imaging/IconProvider/SvgIconProvider.php+2 −2
- typo3/sysext/core/Classes/Imaging/GraphicalFunctions.php+38 −37
- typo3/sysext/core/Classes/Imaging/IconRegistry.php+1 −1
- typo3/sysext/core/Classes/Imaging/ImageDimension.php+1 −1
- typo3/sysext/core/Classes/LinkHandling/LegacyLinkNotationConverter.php+1 −1
- typo3/sysext/core/Classes/Localization/Parser/AbstractXmlParser.php+3 −3
- typo3/sysext/core/Classes/Localization/Parser/XliffParser.php+1 −1
- typo3/sysext/core/Classes/Localization/LocalizationFactory.php+2 −1
- typo3/sysext/core/Classes/Log/Writer/FileWriter.php+1 −1
- typo3/sysext/core/Classes/Log/Writer/SyslogWriter.php+2 −2
- typo3/sysext/core/Classes/Mail/FileSpool.php+5 −5
- typo3/sysext/core/Classes/Mail/Mailer.php+1 −1
- typo3/sysext/core/Classes/Mail/MailMessage.php+1 −1
- typo3/sysext/core/Classes/Mail/Rfc822AddressesParser.php+8 −8
- typo3/sysext/core/Classes/Package/PackageManager.php+3 −3
- typo3/sysext/core/Classes/Page/PageRenderer.php1+11 −9
- typo3/sysext/core/Classes/Resource/Driver/DriverRegistry.php1+4 −1
- typo3/sysext/core/Classes/Resource/Driver/LocalDriver.php+5 −5
- typo3/sysext/core/Classes/Resource/Index/FileIndexRepository.php1+4 −4
- typo3/sysext/core/Classes/Resource/Rendering/AudioTagRenderer.php+1 −1
- typo3/sysext/core/Classes/Resource/Rendering/VideoTagRenderer.php+1 −1
- typo3/sysext/core/Classes/Resource/Search/QueryRestrictions/SearchTermRestriction.php+1 −1
- typo3/sysext/core/Classes/Resource/Search/Result/FileSearchResult.php+1 −1
- typo3/sysext/core/Classes/Resource/Search/FileSearchQuery.php2+6 −4
- typo3/sysext/core/Classes/Resource/Security/FileMetadataPermissionsAspect.php+3 −3
- typo3/sysext/core/Classes/Resource/Service/UserFileInlineLabelService.php+1 −1
- typo3/sysext/core/Classes/Resource/TextExtraction/PlainTextExtractor.php+1 −1
- typo3/sysext/core/Classes/Resource/Folder.php+1 −1
- typo3/sysext/core/Classes/Resource/ResourceCompressor.php+9 −9
- typo3/sysext/core/Classes/Resource/ResourceFactory.php+7 −6
- typo3/sysext/core/Classes/Resource/ResourceStorage.php+1 −1
- typo3/sysext/core/Classes/Resource/StorageRepository.php+2 −2
- typo3/sysext/core/Classes/Routing/PageRouter.php+3 −3
- typo3/sysext/core/Classes/Routing/PageSlugCandidateProvider.php+2 −1
- typo3/sysext/core/Classes/Routing/PageUriMatcher.php+2 −2
- typo3/sysext/core/Classes/Routing/SiteMatcher.php+3 −3
- typo3/sysext/core/Classes/Service/Archive/ZipService.php+1 −1
- typo3/sysext/core/Classes/Service/AbstractService.php+2 −2
- typo3/sysext/core/Classes/Service/OpcodeCacheService.php+1 −1
- typo3/sysext/core/Classes/Session/SessionManager.php+1 −1
- typo3/sysext/core/Classes/Site/Entity/NullSite.php+1 −1
- typo3/sysext/core/Classes/TimeTracker/TimeTracker.php+1 −1
- typo3/sysext/core/Classes/Tree/TableConfiguration/DatabaseTreeDataProvider.php+2 −2
- typo3/sysext/core/Classes/Type/File/ImageInfo.php+1 −1
- typo3/sysext/core/Classes/TypoScript/Parser/ConstantConfigurationParser.php+1 −1
- typo3/sysext/core/Classes/TypoScript/Parser/TypoScriptParser.php+36 −28
- typo3/sysext/core/Classes/TypoScript/ExtendedTemplateService.php+15 −15
- typo3/sysext/core/Classes/TypoScript/TemplateService.php+18 −3
- typo3/sysext/core/Classes/Utility/File/BasicFileUtility.php+2 −2
- typo3/sysext/core/Classes/Utility/ArrayUtility.php+2 −2
- typo3/sysext/core/Classes/Utility/CommandUtility.php+1 −1
- typo3/sysext/core/Classes/Utility/CsvUtility.php1+1 −0
- typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php+2 −2
- typo3/sysext/core/Classes/Utility/GeneralUtility.php1+45 −27
- typo3/sysext/core/Classes/Utility/PathUtility.php+5 −5
- typo3/sysext/core/Classes/Utility/VersionNumberUtility.php+2 −2
- typo3/sysext/core/Tests/Functional/Database/Schema/SchemaMigratorTest.php+3 −3
- typo3/sysext/core/Tests/Functional/IO/PharStreamWrapperInterceptorTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Cache/Backend/FileBackendTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/TableBuilderTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Http/StreamFactoryTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Http/UploadedFileTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Localization/LocalesTest.php+4 −4
- typo3/sysext/core/Tests/Unit/Log/Writer/FileWriterTest.php+4 −4
- typo3/sysext/core/Tests/Unit/Resource/ResourceCompressorIntegrationTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Resource/ResourceCompressorTest.php+2 −2
- phpstan.neon+6 −0
Review log 1622
-
Alexander Schnitzler uploaded patch set 1 08/26/20, 13:24
-
Alexander Schnitzler wrote 08/26/20, 13:28
Topic set to phpstan -
TYPO3com voted on patch set 1 V -1 08/26/20, 14:23 Completed build in 45m 53s on Wed, 26 Aug, 02:23 PM Test Summary: 1376 of 71940 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4986
-
TYPO3com commented on patch set 1 08/27/20, 09:04 Completed build in 20h 12m 43s on Thu, 27 Aug, 09:04 AM Test Summary: 1825 of 73577 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4986
-
Alexander Schnitzler uploaded patch set 2 08/28/20, 09:02
-
TYPO3com voted on patch set 2 V -1 08/28/20, 09:14 Completed build in 11m 28s on Fri, 28 Aug, 09:14 AM Test Summary: 73092 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5027
-
Alexander Schnitzler uploaded patch set 3 08/31/20, 08:23
-
TYPO3com voted on patch set 3 V +1 08/31/20, 08:34 Completed build in 11m 20s on Mon, 31 Aug, 08:34 AM Test Summary: 73146 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5074
-
Jörg Bösche voted on patch set 3 CR +1 08/31/20, 09:49
-
Jörg Bösche commented on patch set 3 V +1 09/01/20, 08:15
No problems using the backend could be found. Verified on master (v11-dev) as admin user. -
Alexander Schnitzler updated the commit message in patch set 4 09/03/20, 15:49
-
TYPO3com voted on patch set 4 V +1 09/03/20, 16:36 Completed build in 39m 07s on Thu, 3 Sep, 04:36 PM Test Summary: 73182 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5192
-
Oliver Klee commented on patch set 4 09/04/20, 10:35
ExpressionBuilder.php:20UnresolvedIs this used anywhere in this file?PageRenderer.php:1394UnresolvedThis contradicts the @param annotation above - it should either be both Package or both PackageInterface. Anayway, do we still need these two annotation if the @param is updated as above?DriverRegistry.php:51Unresolvedstring|nullFileIndexRepository.php:98UnresolvedWouldn't an int cast suffice here?FileSearchQuery.php:74UnresolvedPlease let's move this assignment out of the condition.FileSearchQuery.php:143UnresolvedPlease let's move this assignment out of the condition.CsvUtility.php:43UnresolvedCan we please split this into two statements? I find the combined ? and ?? operators really hard to wrap my head around.GeneralUtility.php:46UnresolvedWhere is this used? -
Oliver Klee voted on patch set 4 CR -1 09/04/20, 10:37
-
Alexander Schnitzler uploaded patch set 5 09/04/20, 10:56
-
TYPO3com voted on patch set 5 V +1 09/04/20, 11:12 Completed build in 14m 28s on Fri, 4 Sep, 11:12 AM Test Summary: 73200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5230
-
Oliver Klee voted on patch set 5 CR +1 09/04/20, 12:44
-
Jörg Bösche voted on patch set 5 V +1 CR +1 09/07/20, 07:45
-
Sascha Egerer commented on patch set 5 CR -1 09/09/20, 15:32
Just reviewed a first set of changesBackendUserAuthentication.php:1300Don't get that code. $alternativeWebmountPoint is casted to int in 1298. Calling intExplode on a integer does not make sense at all, right?FileBackend.php:1101. if `file_get_contents()` returns `false` something really went wrong. I would go for a log message here in that case and do an early return. I think $this->frozen should also not be set to `true` in that case. 2. second parameter for unserialize should be set to `['allowed_classes' => false]` as it does only contain an array of booleansPdoBackend.php:286if $sql is empty or false we can do an early return instead. $sql = file($pathAndFilename, FILE_IGNORE_NEW_LINES & FILE_SKIP_EMPTY_LINES); if (empty($sql)) { return ''; } -
Alexander Schnitzler commented on patch set 5 09/09/20, 16:36
BackendUserAuthentication.php:1300Reply UnresolvedYep, me neither. That's a part where I simply made phpstan happy. I didn't find any documentation on pageTree_temporaryMountPoint but I guess it's really an int and we can drop the whole intExplode here.FileBackend.php:110Reply UnresolvedAgree on 1). I fits to the scope if this patch. 2) is a different issue imo.PdoBackend.php:286Reply UnresolvedYep, saves some cpu cycles. -
Sascha Egerer commented on patch set 5 09/09/20, 17:29
I've split up this patch into smaller parts as discussed in slack. So i would opt to close abandon this one -
Alexander Schnitzler abandoned the change 09/22/20, 12:17
Patch has been split into smaller chunks