65467[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:form
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Oliver Klee +1
- Anja Leichsenring +1
- Christian Kuhn +1
-
Verified V +2 Done
- Daniel Goerz +2
- Anja Leichsenring +1
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 1
Files 20
- typo3/sysext/form/Classes/Controller/FormManagerController.php+2 −2
- typo3/sysext/form/Classes/Domain/Finishers/ConfirmationFinisher.php+1 −0
- typo3/sysext/form/Classes/Domain/Finishers/EmailFinisher.php+2 −0
- typo3/sysext/form/Classes/Domain/Finishers/RedirectFinisher.php1+4 −1
- typo3/sysext/form/Classes/Domain/Finishers/SaveToDatabaseFinisher.php+3 −1
- typo3/sysext/form/Classes/Domain/Model/FormElements/AbstractFormElement.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/FormElements/UnknownFormElement.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Renderable/AbstractRenderable.php+1 −0
- typo3/sysext/form/Classes/Domain/Model/FormDefinition.php+2 −0
- typo3/sysext/form/Classes/Hooks/FormFileExtensionUpdate.php+3 −1
- typo3/sysext/form/Classes/Mvc/Persistence/FormPersistenceManager.php+3 −1
- typo3/sysext/form/Classes/Mvc/Property/TypeConverter/UploadedFileReferenceConverter.php1+4 −0
- typo3/sysext/form/Classes/Mvc/Validation/CountValidator.php+2 −2
- typo3/sysext/form/Classes/Mvc/Validation/DateRangeValidator.php+3 −3
- typo3/sysext/form/Classes/Mvc/Validation/EmptyValidator.php+1 −1
- typo3/sysext/form/Classes/Mvc/Validation/FileSizeValidator.php+3 −3
- typo3/sysext/form/Classes/Mvc/Validation/MimeTypeValidator.php+2 −2
- typo3/sysext/form/Classes/Service/TranslationService.php1+2 −2
- typo3/sysext/form/Classes/Slot/FilePersistenceSlot.php+2 −2
- typo3/sysext/form/Classes/ViewHelpers/GridColumnClassAutoConfigurationViewHelper.php+1 −1
Review log 1926
Show 1 earlier messages
-
Alexander Schnitzler uploaded patch set 1 08/26/20, 13:42
-
Alexander Schnitzler wrote 08/26/20, 13:43
Topic set to phpstan -
TYPO3com voted on patch set 1 V -1 08/26/20, 14:42 Completed build in 41m 31s on Wed, 26 Aug, 02:42 PM Test Summary: 178 of 63145 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4989
-
TYPO3com commented on patch set 1 08/27/20, 08:09 Completed build in 18h 50m 01s on Thu, 27 Aug, 08:09 AM Test Summary: 1 of 73577 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4989
-
TYPO3com voted on patch set 1 V +1 08/27/20, 08:22 Completed build in 13h 11m 22s on Thu, 27 Aug, 08:22 AM Test Summary: 73092 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4989
-
Oliver Klee voted on patch set 1 CR +1 08/28/20, 16:50
-
Jörg Bösche voted on patch set 1 CR +1 08/31/20, 08:56
-
Alexander Schnitzler updated the commit message in patch set 2 09/03/20, 15:50
-
TYPO3com voted on patch set 2 V +1 09/03/20, 16:24 Completed build in 26m 55s on Thu, 3 Sep, 04:24 PM Test Summary: 73182 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5193
-
Oliver Klee voted on patch set 2 CR +1 09/04/20, 07:50
-
Daniel Goerz uploaded patch set 3 09/04/20, 15:07
-
TYPO3com voted on patch set 3 V +1 09/04/20, 15:19 Completed build in 11m 57s on Fri, 4 Sep, 03:19 PM Test Summary: 73206 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5245
-
Daniel Goerz voted on patch set 3 V +1 CR +1 09/04/20, 15:20
-
Oliver Klee voted on patch set 3 CR +1 09/04/20, 16:41
-
Christian Kuhn uploaded patch set 4 09/08/20, 19:37
-
Christian Kuhn commented on patch set 3 09/08/20, 19:37
UploadedFileReferenceConverter.php:152Unresolvedi think it's safer to move the exception down a bit - below other returns and before first use of $configurationTranslationService.php:474Unresolvedthat's actually a bugfix -
TYPO3com voted on patch set 4 V -1 09/08/20, 19:37 Completed build in 23s on Tue, 8 Sep, 07:37 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5377
-
Anja Leichsenring voted on patch set 4 V +1 CR +1 09/08/20, 19:37
-
Christian Kuhn uploaded patch set 5 09/08/20, 19:38
-
Anja Leichsenring voted on patch set 5 V +1 CR +1 09/08/20, 19:38
-
Christian Kuhn voted on patch set 5 V +1 CR +1 09/08/20, 19:39
-
TYPO3com voted on patch set 5 V +1 09/08/20, 19:50 Completed build in 11m 41s on Tue, 8 Sep, 07:50 PM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5378
-
Oliver Klee voted on patch set 5 CR +1 09/08/20, 20:03
-
Daniel Goerz voted on patch set 5 V +2 CR +2 09/09/20, 06:50
-
Daniel Goerz merged patch set 6 09/09/20, 06:50
-
Andreas Kienast commented on patch set 6 11/27/20, 15:18
RedirectFinisher.php:70UnresolvedThis is a breaking change if the RedirectFinisher is configured via PHP and pageUid contains an integer. 😞