Review main Merged

65467[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:form

Alexander Schnitzler CR +2 V +2 Normal +43 −24 updated 11/27/20, 15:18

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oliver Klee +1
    • Anja Leichsenring +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 20

Review log 1926

Show 1 earlier messages
  1. Alexander Schnitzler uploaded patch set 1 08/26/20, 13:42

  1. Alexander Schnitzler wrote 08/26/20, 13:43

    Topic set to phpstan
  2. TYPO3com voted on patch set 1 V -1 08/26/20, 14:42 Completed build in 41m 31s on Wed, 26 Aug, 02:42 PM Test Summary: 178 of 63145 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4989

  3. TYPO3com commented on patch set 1 08/27/20, 08:09 Completed build in 18h 50m 01s on Thu, 27 Aug, 08:09 AM Test Summary: 1 of 73577 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4989

  4. TYPO3com voted on patch set 1 V +1 08/27/20, 08:22 Completed build in 13h 11m 22s on Thu, 27 Aug, 08:22 AM Test Summary: 73092 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4989

  5. Oliver Klee voted on patch set 1 CR +1 08/28/20, 16:50

  6. Jörg Bösche voted on patch set 1 CR +1 08/31/20, 08:56

  7. Alexander Schnitzler updated the commit message in patch set 2 09/03/20, 15:50

  8. TYPO3com voted on patch set 2 V +1 09/03/20, 16:24 Completed build in 26m 55s on Thu, 3 Sep, 04:24 PM Test Summary: 73182 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5193

  9. Oliver Klee voted on patch set 2 CR +1 09/04/20, 07:50

  10. Daniel Goerz uploaded patch set 3 09/04/20, 15:07

  11. TYPO3com voted on patch set 3 V +1 09/04/20, 15:19 Completed build in 11m 57s on Fri, 4 Sep, 03:19 PM Test Summary: 73206 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5245

  12. Daniel Goerz voted on patch set 3 V +1 CR +1 09/04/20, 15:20

  13. Oliver Klee voted on patch set 3 CR +1 09/04/20, 16:41

  14. Christian Kuhn uploaded patch set 4 09/08/20, 19:37

  15. Christian Kuhn commented on patch set 3 09/08/20, 19:37

    UploadedFileReferenceConverter.php:152 Unresolved

    i think it's safer to move the exception down a bit - below other returns and before first use of $configuration

    TranslationService.php:474 Unresolved

    that's actually a bugfix
  16. TYPO3com voted on patch set 4 V -1 09/08/20, 19:37 Completed build in 23s on Tue, 8 Sep, 07:37 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5377

  17. Anja Leichsenring voted on patch set 4 V +1 CR +1 09/08/20, 19:37

  18. Christian Kuhn uploaded patch set 5 09/08/20, 19:38

  19. Anja Leichsenring voted on patch set 5 V +1 CR +1 09/08/20, 19:38

  20. Christian Kuhn voted on patch set 5 V +1 CR +1 09/08/20, 19:39

  21. TYPO3com voted on patch set 5 V +1 09/08/20, 19:50 Completed build in 11m 41s on Tue, 8 Sep, 07:50 PM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5378

  22. Oliver Klee voted on patch set 5 CR +1 09/08/20, 20:03

  23. Daniel Goerz voted on patch set 5 V +2 CR +2 09/09/20, 06:50

  24. Daniel Goerz merged patch set 6 09/09/20, 06:50

  25. Andreas Kienast commented on patch set 6 11/27/20, 15:18

    RedirectFinisher.php:70 Unresolved

    This is a breaking change if the RedirectFinisher is configured via PHP and pageUid contains an integer. 😞