Review 10.4 Merged

65468[BUGFIX] Wrap operands in parentheses

Andreas Kienast CR +2 V +2 Easy +9 −9 updated 08/28/20, 14:51

Commit message

This patch wraps operands in parentheses which could otherwise cause
unwanted side-effects. In most cases null coalesce operators are
affected.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Jörg Bösche +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 46

  1. Andreas Kienast uploaded patch set 1 08/26/20, 13:46

  2. TYPO3com voted on patch set 1 V -1 08/26/20, 14:57 Completed build in 56m 42s on Wed, 26 Aug, 02:57 PM Test Summary: 70 of 73671 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-280

  3. TYPO3com voted on patch set 1 V +1 08/27/20, 09:00 Completed build in 40m 00s on Thu, 27 Aug, 09:00 AM Test Summary: 74061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-287

  4. Jörg Bösche commented on patch set 1 V +1 CR +1 08/27/20, 10:43

    Verified on version 10.4 with PHP 7.3. Works like a charm!
  5. Andreas Kienast voted on patch set 1 V +2 CR +2 08/28/20, 14:51

  6. Andreas Kienast merged patch set 2 08/28/20, 14:51