Review main Merged

65471[TASK] DatabaseRecordList: Drop property counter

Daniel Windloff CR +2 V +2 Easy +0 −11 updated 08/28/20, 13:35

Commit message

The property `counter` is not used anymore, so it's getting removed.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
    • Jörg Bösche +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1113

  1. Daniel Windloff uploaded patch set 1 08/27/20, 08:54

  2. Oliver Klee voted on patch set 1 CR +1 08/27/20, 09:07

  3. TYPO3com voted on patch set 1 V +1 08/27/20, 09:16 Completed build in 18m 52s on Thu, 27 Aug, 09:16 AM Test Summary: 73092 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5000

  4. Jörg Bösche voted on patch set 1 CR +1 08/27/20, 10:38

  5. Christian Kuhn voted on patch set 1 V +1 CR +1 08/27/20, 12:24

  6. Björn Jacob voted on patch set 1 CR +1 08/28/20, 04:52

  7. Andreas Kienast updated the commit message in patch set 2 08/28/20, 13:13

  8. Andreas Kienast voted on patch set 2 V +1 CR +1 08/28/20, 13:13

  9. Christian Kuhn voted on patch set 2 V +1 CR +1 08/28/20, 13:14

  10. Jörg Bösche voted on patch set 2 V +1 CR +1 08/28/20, 13:17

  11. TYPO3com voted on patch set 2 V +1 08/28/20, 13:29 Completed build in 13m 31s on Fri, 28 Aug, 01:29 PM Test Summary: 73092 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5033

  12. Andreas Kienast voted on patch set 2 V +2 CR +2 08/28/20, 13:35

  13. Andreas Kienast merged patch set 3 08/28/20, 13:35