Review 10.4 Merged

65473[BUGFIX] Properly set user to admin in setup module

Andreas Kienast CR +2 V +2 Easy +8 −3 updated 08/27/20, 08:17

Commit message

SetupModuleController serves as a backdoor so regular users without
permission to manipulate be_users records can still edit their profile.
For this to work, the access check needs to be bypassed for this
particular record by DataHandler.

The start() method of DataHandler prepares e.g. exclude fields to be checked.
With current code, incoming user is not yet set to admin, so exclude field
checking may fail, especially if 3rd party extensions manipulate this.
The patch hands a temporary user with activated admin flag to DataHandler,
so it can bypass the access check for profile editing.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 38

  1. Andreas Kienast commented on patch set 1 08/26/20, 12:48

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V -1 08/26/20, 13:14 Completed build in 25m 32s on Wed, 26 Aug, 01:14 PM Test Summary: 10 of 74528 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-277

  3. TYPO3com commented on patch set 1 08/26/20, 13:44 Completed build in 1h 21m 02s on Wed, 26 Aug, 01:44 PM Test Summary: 7 of 74528 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-277

  4. TYPO3com commented on patch set 1 08/26/20, 14:47 Completed build in 45m 50s on Wed, 26 Aug, 02:47 PM Test Summary: 1 of 74528 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-281

  5. TYPO3com commented on patch set 1 08/26/20, 14:56 Completed build in 55m 09s on Wed, 26 Aug, 02:56 PM Test Summary: 12 of 73997 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-282

  6. TYPO3com voted on patch set 1 V +1 08/27/20, 07:16 Completed build in 12m 39s on Thu, 27 Aug, 07:16 AM Test Summary: 74043 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-284

  7. Andreas Kienast voted on patch set 1 V +2 CR +2 08/27/20, 08:17

  8. Andreas Kienast merged patch set 2 08/27/20, 08:17