Review 10.4 Merged

65480[BUGFIX] DB check -> full search shows deleted records if requested

Christian Kuhn CR +2 V +2 Easy +15 −18 updated 08/31/20, 18:22

Commit message

With #82729 the $GLOBALS['SOBE'] = $this; assignment in
DatabaseIntegrityController has been removed. This is a
good thing, however parts of QueryGenerator class still
relied on this.
The patch gives the module settings that have been
introduced for #83428 from QueryView down to
QueryGenerator as well.
This fixes a couple of details, most importantly the
'Show even deleted entries' checkbox of the full search
advanced query view works again.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 3

Files 2

Review log 46

  1. Christian Kuhn commented on patch set 1 08/30/20, 17:59

    Cherry Picked from branch master.
  2. Christian Kuhn updated the commit message in patch set 2 08/30/20, 18:01

  3. TYPO3com voted on patch set 1 V +1 08/30/20, 18:12 Completed build in 13m 09s on Sun, 30 Aug, 06:12 PM Test Summary: 74115 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-297

  4. TYPO3com voted on patch set 2 V +1 08/30/20, 18:18 Completed build in 16m 09s on Sun, 30 Aug, 06:18 PM Test Summary: 74115 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-298

  5. Benni Mack voted on patch set 2 V +2 CR +2 08/31/20, 18:22

  6. Benni Mack merged patch set 3 08/31/20, 18:22