Review 9.5 Merged

65481[BUGFIX] Correctly call BackendUtility::selectVersionsOfRecord

Benni Mack CR +2 V +2 Easy +1 −1 updated 08/31/20, 12:16

Commit message

Issue #69135 fixed issue #60249, but introduced an invalid call
to `BackendUtility::selectVersionsOfRecord`. The scope was to
handle all versions in all workspaces (`$workspace=null`).
As a result, without patch, command 'cleanup:versions' reports
too many unused placeholder rows and the action command
'cleanup:versions --action=unused_placeholders' deletes too many.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 3

Files 1

Review log 34

  1. Benni Mack commented on patch set 1 08/31/20, 12:04

    Cherry Picked from branch 10.4.
  2. TYPO3com voted on patch set 1 V +1 08/31/20, 12:16 Completed build in 11m 53s on Mon, 31 Aug, 12:16 PM Test Summary: 75145 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-767

  3. Benni Mack voted on patch set 1 V +2 CR +2 08/31/20, 12:16

  4. Benni Mack merged patch set 2 08/31/20, 12:16