Review 10.4 Merged

65484[BUGFIX] Output messages and progress for language:update

Benni Mack CR +2 V +2 Normal +47 −16 updated 09/01/20, 06:47

Commit message

Always output a progress bar and information that it is
actually doing something even when not called with --verbose

When no output is required or wanted, the global option --quiet
can be used instead.

To further improve the command, --no-progress is added
which removes the progress bar output, and shows messages instead.

Last but not least, output success or error messages for each
of the language pack fetches and exit with error code when
failures occurred.

To not make the command always fail when private extensions are used,
individual extensions can be skipped.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Benni Mack commented on patch set 1 09/01/20, 06:12

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 09/01/20, 06:23 Completed build in 10m 54s on Tue, 1 Sep, 06:23 AM Test Summary: 74115 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-302

  3. Benni Mack voted on patch set 1 V +2 CR +2 09/01/20, 06:47

  4. Benni Mack merged patch set 2 09/01/20, 06:47