Review 10.4 Merged

65485[BUGFIX] Provide EventDispatcher and Logger to transports

Benni Mack CR +2 V +2 Hard +239 −102 updated 09/02/20, 06:40

Commit message

The EventDispatcherInterface and LoggerInterface are now provided to
newly created Symfony\Component\Mailer\Transport\AbstractTransport
decendents. This makes sure all provided events are available.

To be compatible with the Symfony's events interface an adapter is
added which conforms to symfony/event-dispatcher-contracts.

Used composer commands:
- composer require symfony/event-dispatcher-contracts:^2.0 --no-update \
    --working-dir=typo3/sysext/core
- composer require symfony/event-dispatcher-contracts:^2.0 --no-update
- composer update --lock

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Simon Gilli +1
  • Verified V +2 Done
    • Benni Mack +2
    • Simon Gilli +1
    • TYPO3com +1 CI

Issues 1

Files 9

Review log 68

  1. Benni Mack commented on patch set 1 09/01/20, 06:38

    Cherry Picked from branch master. The following files contain Git conflicts: * composer.lock
  2. TYPO3com voted on patch set 1 V -1 09/01/20, 06:39 Completed build in 18s on Tue, 1 Sep, 06:39 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-303

  3. Benni Mack uploaded patch set 2 09/01/20, 16:07

  4. Benni Mack commented on patch set 2 09/01/20, 16:07

    This change is ready for review.
  5. TYPO3com voted on patch set 2 V +1 09/01/20, 16:19 Completed build in 11m 44s on Tue, 1 Sep, 04:19 PM Test Summary: 74133 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-306

  6. Simon Gilli voted on patch set 2 V +1 CR +1 09/01/20, 21:35

  7. Benni Mack voted on patch set 2 V +2 CR +2 09/02/20, 06:40

  8. Benni Mack merged patch set 3 09/02/20, 06:40