Review 10.4 Merged

65486[TASK] Default workspaces_perms=0 for new be_users

Benni Mack CR +2 V +2 Easy +12 −0 updated 09/01/20, 14:39

Commit message

Field workspace_perms=1 for backend users or groups enables
editing of the live workspace.
When ext:workspaces is loaded, we can assume the extension
is actively used in the instance. If so, many backend users
most likely should NOT have live edit access and the flag
is probably given to only a small group of editors by assigning
a 'chief editor' group or similar that carries the flag.
The patch sets workspace_perms for new backend users by
default to 0 when ext:workspaces is loaded, making it more
unlikely admins accidentially give live edit access to users.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 35

  1. Benni Mack commented on patch set 1 09/01/20, 11:38

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V -1 09/01/20, 11:50 Completed build in 11m 46s on Tue, 1 Sep, 11:50 AM Test Summary: 73785 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-304

  3. TYPO3com voted on patch set 1 V +1 09/01/20, 14:15 Completed build in 2h 48m 16s on Tue, 1 Sep, 02:15 PM Test Summary: 74115 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-304

  4. Benni Mack voted on patch set 1 V +2 CR +2 09/01/20, 14:39

  5. Benni Mack merged patch set 2 09/01/20, 14:39