Review 10.4 Merged

65487[DOCS] Avoid use of TYPO3_MODE checks in ext_localconf.php

Benni Mack CR +2 V +2 Easy +11 −13 updated 09/01/20, 14:41

Commit message

As it's highly discouraged to check for global constants in
ext_localconf.php due to limited caching the example code
is updated to not propose this check anymore.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Benni Mack commented on patch set 1 09/01/20, 14:10

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 09/01/20, 14:24 Completed build in 13m 49s on Tue, 1 Sep, 02:24 PM Test Summary: 74115 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-305

  3. Benni Mack voted on patch set 1 V +2 CR +2 09/01/20, 14:41

  4. Benni Mack merged patch set 2 09/01/20, 14:41