Review main Merged Breaking

65493[!!!][TASK] Drop TCA [ctrl][thumbnail] and user uc[thumbnailsByDefault]

Christian Kuhn CR +2 V +2 Normal +40 −119 updated 08/27/20, 12:19

Commit message

Setting TCA[$someTable]['ctrl']['thumbnail'] to some image related
column made the list module show attached images as preview.
Until core v8, this has been used for tt_content and has been
dropped for this table because two different fields (images, media)
are used and the setting could not cope with that.
For extensions with own tables, this setting has been used
very seldom. It also partially destroys the list module view.

The patch drops evaluation of this ctrl setting in the list module.
With this gone, the 'thumbnailsByDefault' setting of the user settings
module only affects the file list module. The file list module has
it's own checkbox to toggle image preview rendering, so the setup module
checkbox has little benefit and is removed as well. This additionally
fixes a bug that thumbnail preview rendering in file list module can't
be turned off if the setup module checkbox is set.

Additionally, the patch drops some unused css for the list module,
'typo3-dblist' simply does not exist as class.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Daniel Windloff +1
    • Achim Fritz +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Daniel Windloff +1
    • Achim Fritz +1
    • TYPO3com +1 CI

Issues 2

Files 15

Review log 710

  1. Christian Kuhn uploaded patch set 1 08/27/20, 11:00

  2. Christian Kuhn uploaded patch set 2 08/27/20, 11:02

  3. TYPO3com voted on patch set 1 V +1 08/27/20, 11:11 Completed build in 10m 50s on Thu, 27 Aug, 11:11 AM Test Summary: 73092 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5004

  4. TYPO3com voted on patch set 2 V +1 08/27/20, 11:17 Completed build in 15m 03s on Thu, 27 Aug, 11:17 AM Test Summary: 73092 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5005

  5. Christian Kuhn uploaded patch set 3 08/27/20, 11:33

  6. Achim Fritz commented on patch set 3 V +1 CR +1 08/27/20, 11:40

    Tested: * $GLOBALS['TCA']['tt_content']['ctrl']['thumbnail'] = 'image'; is not rendered in list-view * The "Show Thumbnails by default" Checkbox is not rendered in User Settings
  7. TYPO3com voted on patch set 3 V +1 08/27/20, 11:44 Completed build in 10m 44s on Thu, 27 Aug, 11:44 AM Test Summary: 73092 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5007

  8. Daniel Windloff voted on patch set 3 V +1 CR +1 08/27/20, 12:14

  9. Anja Leichsenring voted on patch set 3 V +2 CR +2 08/27/20, 12:18

  10. Anja Leichsenring merged patch set 4 08/27/20, 12:19