65494[BUGFIX] Do not show record history workspace entries in live
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Guido Schmechel +1
- Anja Leichsenring +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Guido Schmechel +1
- Anja Leichsenring +1
- Benni Mack +1
- TYPO3com +1 CI
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/backend/Classes/Controller/ContentElement/ElementHistoryController.php+9 −14
- typo3/sysext/backend/Classes/History/RecordHistory.php+14 −2
- typo3/sysext/backend/Resources/Private/Language/locallang_show_rechis.xlf+3 −0
- typo3/sysext/backend/Resources/Private/Partials/RecordHistory/History.html+23 −11
Review log 1723
-
Christian Kuhn uploaded patch set 1 08/27/20, 12:20
-
Christian Kuhn commented on patch set 1 CR -1 08/27/20, 12:21
needs more work when calling module if in workspace ... -
TYPO3com voted on patch set 1 V +1 08/27/20, 12:36 Completed build in 15m 16s on Thu, 27 Aug, 12:36 PM Test Summary: 73092 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5009
-
Christian Kuhn uploaded patch set 2 08/31/20, 10:10
-
TYPO3com voted on patch set 2 V +1 08/31/20, 10:22 Completed build in 11m 09s on Mon, 31 Aug, 10:22 AM Test Summary: 73146 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5076
-
Christian Kuhn uploaded patch set 3 03/12/21, 17:00
-
TYPO3com voted on patch set 3 V +1 03/12/21, 17:08 Completed build in 07m 53s on Fri, 12 Mar, 05:08 PM Test Summary: 32699 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10091
-
core-ci voted on patch set 3 V +1 03/12/21, 17:11 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1468
-
Oliver Klee commented on patch set 3 03/12/21, 18:48
Please let's reword the commit message title to describe the change, not the old behavior that is changed. -
Christian Kuhn updated the commit message in patch set 4 03/12/21, 21:07
-
TYPO3com voted on patch set 4 V +1 03/12/21, 21:14 Completed build in 06m 56s on Fri, 12 Mar, 09:14 PM Test Summary: 32699 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10098
-
Christian Kuhn commented on patch set 4 03/12/21, 21:16
Reply
do you have any suggestion? the patch drops this feature - how to rephrase? -
Christian Kuhn commented on patch set 4 03/12/21, 21:17
Reply Unresolved
ah, scratch that ... changed this already ... clicked wrong patch ^^ -
core-ci voted on patch set 4 V +1 03/12/21, 21:18 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1475
-
Oliver Klee wrote 03/12/21, 22:27
Removed reviewer Oliver Klee. -
Oliver Klee commented on patch set 4 03/12/21, 22:27
@Christian: Thanks! -
Anja Leichsenring voted on patch set 4 V +1 CR +1 03/14/21, 15:43
-
Guido Schmechel voted on patch set 4 V +1 CR +1 03/14/21, 16:48
-
Guido Schmechel commented on patch set 4 03/14/21, 16:49
Short question: Bugfix for 10.4 isn't planned? -
Benni Mack voted on patch set 4 V +1 CR +1 03/14/21, 17:55
-
Christian Kuhn commented on patch set 4 03/14/21, 18:09
Reply
I skipped v10 here: The backport is not trivial due to a different patch in master before - If anyone steps in, it could be done, but I personally wouldn't commit the effort to take care of the backport here if there is no huge pressure. -
Christian Kuhn voted on patch set 4 V +2 CR +2 03/14/21, 18:09
-
Christian Kuhn merged patch set 5 03/14/21, 18:10