65495[BUGFIX] Workspace delete placeholder handling in list module
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Daniel Windloff +1
- Björn Jacob +1
-
Verified V +2 Done
- Andreas Kienast +2
- Daniel Windloff +1
- Riccardo De Contardi +1
- TYPO3com +1 CI
Issues 2
Files 5
- Build/Sources/Sass/typo3/structure/_module_web_list.scss+8 −0
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
- typo3/sysext/core/Resources/Private/Language/locallang_mod_web_list.xlf+0 −6
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php+130 −87
- typo3/sysext/recordlist/Resources/Private/Language/locallang.xlf+3 −0
Review log 913
-
Christian Kuhn uploaded patch set 1 08/27/20, 14:28
-
Christian Kuhn updated the commit message in patch set 2 08/27/20, 14:29
-
Christian Kuhn uploaded patch set 3 08/27/20, 14:30
-
TYPO3com voted on patch set 1 V +1 08/27/20, 14:40 Completed build in 11m 47s on Thu, 27 Aug, 02:40 PM Test Summary: 73092 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5017
-
TYPO3com voted on patch set 2 V +1 08/27/20, 14:49 Completed build in 18m 29s on Thu, 27 Aug, 02:49 PM Test Summary: 73092 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5018
-
TYPO3com voted on patch set 3 V +1 08/27/20, 14:49 Completed build in 18m 03s on Thu, 27 Aug, 02:49 PM Test Summary: 73092 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5019
-
Christian Kuhn uploaded patch set 4 08/27/20, 15:06
-
TYPO3com voted on patch set 4 V +1 08/27/20, 15:17 Completed build in 10m 37s on Thu, 27 Aug, 03:17 PM Test Summary: 73092 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5020
-
Daniel Windloff voted on patch set 4 V +1 CR +1 08/27/20, 15:20
-
Riccardo De Contardi commented on patch set 4 V +1 08/27/20, 20:55
tested with latest master; the record in list module has no icon to interact with and its title is struck through. -
Björn Jacob voted on patch set 4 CR +1 08/28/20, 04:54
-
Andreas Kienast voted on patch set 4 V +2 CR +2 08/28/20, 13:08
-
Andreas Kienast merged patch set 5 08/28/20, 13:08