Review main Merged Breaking

65502[!!!][TASK] DatabaseRecordList: Drop hook to modify `searchFields`

Daniel Windloff CR +2 V +2 Normal +48 −14 updated 08/30/20, 14:58

Commit message

The TCA configuration `searchFields` in the `ctrl` section has been
introduced in TYPO3 4.6.
This configuration allows setting the search columns. Those columns are
taken into account by the search in the TYPO3 backend.

To enable a smooth transition between TYPO3 4.5 and 4.6, the hook
`$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['mod_list']
['getSearchFieldList']` has been introduced as well. It allows
to set the `searchFields` for the list module's search.

As this transition should be finished now, the hook has been
removed. Extension authors are encouraged to set the `searchFields` via
the TCA configuration.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 911

  1. Daniel Windloff uploaded patch set 1 08/29/20, 06:45

  2. TYPO3com voted on patch set 1 V +1 08/29/20, 06:56 Completed build in 11m 11s on Sat, 29 Aug, 06:56 AM Test Summary: 73092 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5041

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 08/29/20, 11:35

  4. Christian Kuhn voted on patch set 1 V 0 CR 0 08/29/20, 11:38

  5. Christian Kuhn commented on patch set 1 08/29/20, 11:40

    The ArrayDimensionMatcher could have a config for this hook usage so the install tool extension scanner finds them.
  6. Daniel Windloff uploaded patch set 2 08/30/20, 08:50

  7. TYPO3com voted on patch set 2 V +1 08/30/20, 09:01 Completed build in 10m 57s on Sun, 30 Aug, 09:01 AM Test Summary: 73092 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5051

  8. Oliver Klee voted on patch set 2 CR +1 08/30/20, 10:44

  9. Christian Kuhn voted on patch set 2 V +1 CR +1 08/30/20, 10:44

  10. Anja Leichsenring voted on patch set 2 V +2 CR +2 08/30/20, 14:58

  11. Anja Leichsenring merged patch set 3 08/30/20, 14:58