65503[!!!][TASK] Refactor create bookmark handling
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Andreas Kienast +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Andreas Kienast +1
- TYPO3com +1 CI
Issues 1
Files 39
- typo3/sysext/backend/Classes/Controller/ContentElement/NewContentElementController.php+0 −1
- typo3/sysext/backend/Classes/Controller/Page/NewMultiplePagesController.php+1 −4
- typo3/sysext/backend/Classes/Controller/Page/SortSubPagesController.php+1 −4
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+22 −12
- typo3/sysext/backend/Classes/Controller/HelpController.php2+10 −7
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php+10 −8
- typo3/sysext/backend/Classes/Controller/SimpleDataHandlerController.php+0 −2
- typo3/sysext/backend/Classes/Controller/SiteConfigurationController.php+13 −10
- typo3/sysext/backend/Classes/Template/Components/Buttons/Action/ShortcutButton.php+84 −48
- typo3/sysext/backend/Classes/Template/ModuleTemplate.php+3 −0
- typo3/sysext/backend/Classes/ViewHelpers/ModuleLayout/Button/ShortcutButtonViewHelper.php+21 −10
- typo3/sysext/beuser/Classes/Controller/BackendUserController.php+3 −0
- typo3/sysext/beuser/Classes/Controller/BackendUserGroupController.php2+7 −0
- typo3/sysext/beuser/Classes/Controller/PermissionController.php+4 −9
- typo3/sysext/beuser/Resources/Private/Layouts/Default.html+4 −1
- typo3/sysext/core/Documentation/Changelog/master/Breaking-92132-LastRemainsOfGlobalsSOBERemoved.rst1new+35 −0
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-92132-DeprecatedShortcutPHPAPI.rstnew+52 −0
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-92132-DeprecatedViewHelperFbebuttonsshortcut.rstnew+37 −0
- typo3/sysext/filelist/Classes/Controller/File/EditFileController.php+0 −6
- typo3/sysext/filelist/Classes/Controller/FileListController.php+7 −4
Show 19 more files
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Buttons/ShortcutViewHelper.php+2 −0
- typo3/sysext/form/Classes/Controller/FormManagerController.php+7 −14
- typo3/sysext/impexp/Classes/Controller/ImportExportController.php+0 −7
- typo3/sysext/info/Classes/Controller/InfoModuleController.php+23 −19
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ArrayGlobalMatcher.php+5 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+42 −0
- typo3/sysext/lowlevel/Classes/Controller/ConfigurationController.php+4 −1
- typo3/sysext/lowlevel/Classes/Controller/DatabaseIntegrityController.php+8 −1
- typo3/sysext/recordlist/Classes/Controller/ElementBrowserController.php+0 −2
- typo3/sysext/recordlist/Classes/Controller/RecordListController.php+1 −1
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php+30 −17
- typo3/sysext/recycler/Classes/Controller/RecyclerModuleController.php+8 −4
- typo3/sysext/redirects/Classes/Controller/ManagementController.php+6 −9
- typo3/sysext/reports/Classes/Controller/ReportController.php+13 −16
- typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php1+14 −2
- typo3/sysext/setup/Classes/Controller/SetupModuleController.php+6 −3
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateModuleController.php+4 −1
- typo3/sysext/viewpage/Classes/Controller/ViewModuleController.php+12 −14
- typo3/sysext/workspaces/Classes/Controller/ReviewController.php+4 −1
Review log 2742
Show 1017 earlier messages
-
Christian Kuhn uploaded patch set 1 08/29/20, 15:43
-
TYPO3com voted on patch set 1 V -1 08/29/20, 15:44 Completed build in 26s on Sat, 29 Aug, 03:44 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5043
-
Christian Kuhn uploaded patch set 2 08/29/20, 15:46
-
TYPO3com voted on patch set 2 V +1 08/29/20, 15:57 Completed build in 10m 53s on Sat, 29 Aug, 03:57 PM Test Summary: 73092 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5044
-
Christian Kuhn uploaded patch set 3 08/29/20, 17:26
-
TYPO3com voted on patch set 3 V +1 08/29/20, 17:37 Completed build in 10m 46s on Sat, 29 Aug, 05:37 PM Test Summary: 73092 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5045
-
Christian Kuhn uploaded patch set 4 08/29/20, 18:33
-
TYPO3com voted on patch set 4 V +1 08/29/20, 18:44 Completed build in 10m 53s on Sat, 29 Aug, 06:44 PM Test Summary: 73092 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5046
-
Christian Kuhn uploaded patch set 5 08/30/20, 12:01
-
TYPO3com voted on patch set 5 V +1 08/30/20, 12:12 Completed build in 11m 26s on Sun, 30 Aug, 12:12 PM Test Summary: 73092 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5052
-
Christian Kuhn uploaded patch set 6 08/30/20, 12:39
-
TYPO3com voted on patch set 6 V +1 08/30/20, 12:51 Completed build in 12m 00s on Sun, 30 Aug, 12:51 PM Test Summary: 73092 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5053
-
Christian Kuhn uploaded patch set 7 08/30/20, 14:01
-
TYPO3com voted on patch set 7 V +1 08/30/20, 14:12 Completed build in 11m 20s on Sun, 30 Aug, 02:12 PM Test Summary: 73098 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5054
-
Christian Kuhn commented on patch set 7 CR -1 08/30/20, 14:46
will rename 'variables' to 'arguments' in the API. -
Christian Kuhn uploaded patch set 8 08/30/20, 15:59
-
Christian Kuhn voted on patch set 8 CR -1 08/30/20, 15:59
-
TYPO3com voted on patch set 8 V +1 08/30/20, 16:10 Completed build in 11m 29s on Sun, 30 Aug, 04:10 PM Test Summary: 73146 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5063
-
Christian Kuhn rebased onto patch set 9 08/31/20, 06:35
-
TYPO3com voted on patch set 9 V +1 08/31/20, 06:47 Completed build in 11m 42s on Mon, 31 Aug, 06:47 AM Test Summary: 73146 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5067
-
Christian Kuhn uploaded patch set 10 08/31/20, 06:50
-
Christian Kuhn uploaded patch set 11 08/31/20, 06:54
-
TYPO3com voted on patch set 10 V +1 08/31/20, 07:04 Completed build in 13m 20s on Mon, 31 Aug, 07:04 AM Test Summary: 73146 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5068
-
TYPO3com voted on patch set 11 V +1 08/31/20, 07:10 Completed build in 15m 38s on Mon, 31 Aug, 07:10 AM Test Summary: 73146 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5069
-
Christian Kuhn uploaded patch set 12 08/31/20, 12:33
-
TYPO3com voted on patch set 12 V +1 08/31/20, 12:47 Completed build in 13m 17s on Mon, 31 Aug, 12:47 PM Test Summary: 73146 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5088
-
Christian Kuhn uploaded patch set 13 09/01/20, 07:00
-
TYPO3com voted on patch set 13 V +1 09/01/20, 07:12 Completed build in 11m 46s on Tue, 1 Sep, 07:12 AM Test Summary: 73164 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5093
-
Christian Kuhn uploaded patch set 14 09/02/20, 09:31
-
TYPO3com voted on patch set 14 V +1 09/02/20, 09:41 Completed build in 10m 42s on Wed, 2 Sep, 09:41 AM Test Summary: 73164 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5126
-
Anja Leichsenring commented on patch set 14 09/02/20, 19:57
I tested around and found some issues with the label creation for the bookmarks menu. Please find the corresponding screenshots attached to the forge issue. The same issues were there before the patch, I think this is the perfect opportunity to fix that while you are on it. -
Benni Mack commented on patch set 14 09/04/20, 09:46
please also see https://forge.typo3.org/issues/42109 -
Christian Kuhn commented on patch set 14 09/04/20, 09:48
> Patch Set 14: > > I tested around and found some issues with the label creation for the bookmarks menu. Please find the corresponding screenshots attached to the forge issue. > The same issues were there before the patch, I think this is the perfect opportunity to fix that while you are on it. Yeah. The descriptions are quite stupid sometimes. There is more magic that should be made explicit instead. This should be another patch. -
Christian Kuhn commented on patch set 14 09/04/20, 09:49
> Patch Set 14: > > please also see https://forge.typo3.org/issues/42109 Yeah. Problem is we probably shouldn't just add the workspace param everywhere. Unsure how to resolve the issue and clearly a different patch. -
Alexander Schnitzler commented on patch set 14 09/04/20, 10:19
I tried reviewing this patch but I feel like there are too much things being changed at the same time. Is it possible to break down the patch into at least two pieces?HelpController.php:173What happened to this check? -
Christian Kuhn commented on patch set 14 09/04/20, 16:02
Hmm, I thought the patch in itself is quite cohesive and only changes what is connected: The api change with usage adaptions and the sobe stuff as (quite obvious) drive-by. I could hack it into more pieces but don't see a huge benefit with it. Do you see a significant improvement that is really required if we split this somehow?HelpController.php:173Reply UnresolvedThe shortcut button object does that internally, too, so the check is not needed. -
Andreas Kienast commented on patch set 14 V -1 CR -1 09/05/20, 08:37
on itBackendUserGroupController.php:99Since backend user comparison works with states only, I'd question whether bookmarking this module makes sense at all.Breaking-92132-LastRemainsOfGlobalsSOBERemoved.rst:4UnresolvedCommit subject must have [!!!] prefix thenSchedulerModuleController.php:1376UnresolvedI can set a bookmark in a scheduler task edit view, but the bookmark will always lead me to the main module. -
Andreas Kienast uploaded patch set 15 09/05/20, 08:39
-
Andreas Kienast commented on patch set 15 V +1 CR +1 09/05/20, 08:40
BackendUserGroupController.php:99Reply Unresolvedmeh, that's not that easy possible without adding more hacks in the template. -
TYPO3com voted on patch set 15 V +1 09/05/20, 08:53 Completed build in 13m 15s on Sat, 5 Sep, 08:53 AM Test Summary: 73206 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5258
-
Anja Leichsenring voted on patch set 15 V +2 CR +2 09/05/20, 09:28
-
Anja Leichsenring merged patch set 16 09/05/20, 09:28